bug#47620: [PATCH] Allow complex key bindings in project-switch-project

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#47620: [PATCH] Allow complex key bindings in project-switch-project

Dario Gjorgjevski
Hi,

project-switch-project currently only allows for single-char bindings to
be used for its commands.  Starting with emacs -Q, evaluate

    (require 'project)
    (define-key project-prefix-map (kbd "M-s g") 'rgrep)
    (add-to-list 'project-switch-commands '(rgrep "grep"))

and then run project-switch-project (by default bound to C-x p p) and
choose a project (hopefully you already have one available).  You will
see "[M-s g] grep" shown in the prompt, but you will not be able to
choose it by typing M-s g.

The patch attached bellow allows for any kind of key binding to be used.
Admittedly, there may be a better way to do it since I did not spend
much time looking into it.

Please, share your thoughts.

Best regards,
Dario


--
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid

0001-Allow-complex-key-bindings-in-project-switch-project.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#47620: [PATCH] Allow complex key bindings in project-switch-project

Dmitry Gutov
Hi Dario,

On 06.04.2021 17:57, Dario Gjorgjevski wrote:

> project-switch-project currently only allows for single-char bindings to
> be used for its commands.  Starting with emacs -Q, evaluate
>
>      (require 'project)
>      (define-key project-prefix-map (kbd "M-s g") 'rgrep)
>      (add-to-list 'project-switch-commands '(rgrep "grep"))
>
> and then run project-switch-project (by default bound to C-x p p) and
> choose a project (hopefully you already have one available).  You will
> see "[M-s g] grep" shown in the prompt, but you will not be able to
> choose it by typing M-s g.
>
> The patch attached bellow allows for any kind of key binding to be used.
> Admittedly, there may be a better way to do it since I did not spend
> much time looking into it.
>
> Please, share your thoughts.

Thanks for the patch, it's a nice addition.

Note that it broke the ability to 'C-g' out of the second prompt, see
the follow-up commit 1ff7cde102.

Likewise, any proposals with a better way to do this are welcome.

(Meantime, closing.)