bug#46491: [feature/pgtk] Unused macro warning in image.c without ImageMagick
X-Debbugs-Cc: Yuuki Harano <[hidden email]>
The following is the only build warning I currently get on feature/pgtk:
image.c:110: warning: macro "DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE"
is not used [-Wunused-macros]
110 | # define DONT_CREATE_TRANSFORMED_IMAGEMAGICK_IMAGE
Is the attached patch the right fix? If so, I can push it after adding
the bug#number to it.
In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
of 2021-02-13 built on tia
Repository revision: 175ebb010477ff0e174fe5145154397f43dee2d2
Repository branch: feature/pgtk
Windowing system distributor 'System Description: Debian GNU/Linux bullseye/sid
> On Sat, 13 Feb 2021 16:34:22 +0000,
> "Basil L. Contovounesios" <[hidden email]> wrote:
>> Is the attached patch the right fix? If so, I can push it after adding
>> the bug#number to it.
> Thanks, confirmed. Please push it.
> Date: Sun, 14 Feb 2021 10:03:25 +0000
> From: Alan Third <[hidden email]>
> Cc: [hidden email], [hidden email] >
> > I wanted to make imagemagick images not blurry in image-mode on
> > scale x2.0 monitor.
> > With the exclusion, imagemagick generates scaled image pixel data,
> > and the image is rendered twice in size, so it is blurry.
> > Without the exclusion, imagemagick generates original image pixel data,
> > and the image may not be enlarged (but shrinked), so it may not be blurry.
> > For other than imagemagick, like png, original image pixel data is generated,
> > and it is not blurry on scale x2.0 monitor.
> I am aware of this, I see the same thing on NS, but when native
> transforms were introduced we decided that when a user asks
> imagemagick to modify an image, imagemagick should actually do the
> modifications and Emacs will just display the results.
> I don't know that it's important, though.
I think it's quite important to have Emacs behave the same on all
platforms. While we no longer recommend to build Emacs with
ImageMagick, those who do build with it should be able to use its
transforms, and disabling that is not necessarily a good idea.
Instead of disabling ImageMagick transforms, why not tell users to
build Emacs without ImageMagick?