bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float

Andrii Kolomoiets
Andrii Kolomoiets <[hidden email]> writes:

> Christian Tietze <[hidden email]> writes:
>
>> Hi Andrii,
>
> Hi Christian
>
>> Your Emacs patch for (non)retina screens and frame sizes introduced a
>> very weird bug where on the non-retina screen, the contents of the
>> frame are drawn in 1/4th the available drawing space. It looks fine on
>> the retina screen, though.
>>
>> See screenshots:
>> https://github.com/daviderestivo/homebrew-emacs-head/issues/92
>>
>> I cannot offer a fix suggestion for this, because I don't know the
>> emacs source well. Maybe you know something from the top of your head?
>
> I'll take a look.

With the commit 0e2b123a4ef600f5b337972a7bb61c1fc4b7d0cd I have no
issue moving frame to the non-retina screen.  The issue appears for me
with the commit 68bd6f3ea9c05637501139c46f1f4304482db95f.

I suspect your issue were introduced in Bug#46155



Reply | Threaded
Open this post in threaded view
|

bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float

Alan Third
On Fri, Feb 19, 2021 at 02:04:24PM +0100, Lars Ingebrigtsen wrote:
> Andrii Kolomoiets <[hidden email]> writes:
>
> > With the commit 0e2b123a4ef600f5b337972a7bb61c1fc4b7d0cd I have no
> > issue moving frame to the non-retina screen.  The issue appears for me
> > with the commit 68bd6f3ea9c05637501139c46f1f4304482db95f.
> >
> > I suspect your issue were introduced in Bug#46155
>
> OK; adding Alan to the CCs.

Fix pushed as 283f98353fe3549ac8f66a3ab8fba85d93c81a88.

--
Alan Third



Reply | Threaded
Open this post in threaded view
|

bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float

Lars Ingebrigtsen
Alan Third <[hidden email]> writes:

>> OK; adding Alan to the CCs.
>
> Fix pushed as 283f98353fe3549ac8f66a3ab8fba85d93c81a88.

Thanks.  Christian, would it be possible for you to update Emacs 28 and
confirm that this fixes the problem you were seeing?

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



Reply | Threaded
Open this post in threaded view
|

bug#46406: 28.0.50; [PATCH] Use frame monitor in frame_float

Lars Ingebrigtsen
Christian Tietze <[hidden email]> writes:

>> On 20. Feb 2021, at 14:00, Lars Ingebrigtsen <[hidden email]> wrote:
>>
>> Thanks.  Christian, would it be possible for you to update Emacs 28 and
>> confirm that this fixes the problem you were seeing?
>
> Compiled from source and it looks good on both displays!

Thanks for checking; closing this bug report, then.

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no