bug#45811: 28.0.50; [PATCH] Respect remember-save-after-remembering on remember-diary-extract-entries

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#45811: 28.0.50; [PATCH] Respect remember-save-after-remembering on remember-diary-extract-entries

Gabriel do Nascimento Ribeiro
On remember.el, when option 'remember-handler-functions' contains
handler 'remember-diary-extract-entries', entries will be appended to
Diary file. However, the Diary file will not be saved automatically. I
could not find any documentation describing if this behavior is
expected, and the docstring for 'remember-save-after-remembering' does
not mention how the Diary file should be handled in this case. Given
that, there is a patch attached to automatically save the Diary file
when option 'remember-save-after-remembering' is 't'. If this is the
wrong behavior, we could improve the improve the docstring or show the
Diary buffer to user after data is appended.


0001-Respect-remember-save-after-remembering-on-remember-.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#45811: 28.0.50; [PATCH] Respect remember-save-after-remembering on remember-diary-extract-entries

Gabriel do Nascimento Ribeiro
Lars Ingebrigtsen <[hidden email]> writes:

> This (and the other two patches) to remember.el look good to me, but are
> too large (in total) to be applied without assigning the copyright for
> the changes to the FSF.  Would you be willing to sign such paperwork?

Yes, sure! Just send me the paperwork and the instructions on how to
sign it.

Thank you.



Reply | Threaded
Open this post in threaded view
|

bug#45811: 28.0.50; [PATCH] Respect remember-save-after-remembering on remember-diary-extract-entries

Lars Ingebrigtsen
Gabriel do Nascimento Ribeiro <[hidden email]> writes:

> Lars Ingebrigtsen <[hidden email]> writes:
>
>> This (and the other two patches) to remember.el look good to me, but are
>> too large (in total) to be applied without assigning the copyright for
>> the changes to the FSF.  Would you be willing to sign such paperwork?
>
> Yes, sure! Just send me the paperwork and the instructions on how to
> sign it.

Great!

Here's how to get started:

Please email the following information to [hidden email], and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]