bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

Protesilaos Stavrou
Commit c1b0515952 to Emacs 'master' on August 27 added two new themes.
Their version was 0.12.0.  A new version is now available, as well as a
texinfo file that documents all their customisation options.  Please see
the attached patch.

Now some administrative considerations:

+ The two themes are also available in GNU ELPA.  What is the best way
  to ensure that we sync between emacs.git and elpa.git?  GNU ELPA has
  hitherto pulled from dedicated branches on my upstream git repository.
  Maybe it would be better/easier to start building directly from the
  Emacs source?  This would reduce the overall workload.

+ Sending attachments with large diffs has the downside of losing the
  commit history.  Do Emacs maintainers wish to keep track of it?  If
  so, what would be the best way to preserve it, seeing as I am
  developing them on my own upstream?  For context, the Leuven theme,
  which is also developed externally, only gets updated in relatively
  large increments, such as in commits to Emacs 'master' 99f8a1c917,
  b5ccc1beb3, and 95e509140e.

+ Should the texinfo file be mentioned in the NEWS entry about the two
  themes?  The attached patch does not include such a change.

I am prepared to do whatever the maintainers consider necessary.  Thank
you for your time!

Best regards,
Protesilaos

--
Protesilaos Stavrou
protesilaos.com

0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch (495K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

Stefan Kangas-2
Protesilaos Stavrou <[hidden email]> writes:

> Commit c1b0515952 to Emacs 'master' on August 27 added two new themes.
> Their version was 0.12.0.  A new version is now available, as well as a
> texinfo file that documents all their customisation options.  Please see
> the attached patch.

Thanks.

The patch doesn't apply cleanly here, I guess due to some ^M characters
that sneaked in:

128 git … apply --3way --
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch:25:
trailing whitespace.
\input texinfo    @c -*- texinfo -*-
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch:26:
trailing whitespace.
@c %**start of header
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch:27:
trailing whitespace.
@setfilename modus-themes.info
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch:28:
trailing whitespace.
@settitle Modus themes for GNU Emacs
/home/skangas/wip/emacs/0001-Update-modus-operandi-modus-vivendi-to-0.13.0.patch:29:
trailing whitespace.
@documentencoding UTF-8
error: corrupt patch at line 2867

(This could be fixed using something like `tr -d '^M'`, I think.)



Reply | Threaded
Open this post in threaded view
|

bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

Stefan Kangas-2
In reply to this post by Protesilaos Stavrou
Protesilaos Stavrou <[hidden email]> writes:

> + The two themes are also available in GNU ELPA.  What is the best way
>   to ensure that we sync between emacs.git and elpa.git?  GNU ELPA has
>   hitherto pulled from dedicated branches on my upstream git repository.
>   Maybe it would be better/easier to start building directly from the
>   Emacs source?  This would reduce the overall workload.

What does "start building directly from the Emacs source" mean here?

FWIW, I don't think we should feel too bound to any particular process;
this seems like a practical matter where we should try to do whatever
is most practical.

> + Sending attachments with large diffs has the downside of losing the
>   commit history.  Do Emacs maintainers wish to keep track of it?  If
>   so, what would be the best way to preserve it, seeing as I am
>   developing them on my own upstream?

I don't think we generally worry about preserving history for packages
managed externally.  We just sync the latest version.

(If one really would like to preserve it, it could perhaps be done with
some git magic.  I'm not sure it's worth the extra effort.)

> + Should the texinfo file be mentioned in the NEWS entry about the two
>   themes?  The attached patch does not include such a change.

We could of course add a NEWS entry for it.  Would you like to propose
one?



Reply | Threaded
Open this post in threaded view
|

bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

Protesilaos Stavrou
On 2020-10-16, 10:13 -0700, Stefan Kangas <[hidden email]> wrote:

> Protesilaos Stavrou <[hidden email]> writes:
>
>> + The two themes are also available in GNU ELPA.  What is the best way
>>   to ensure that we sync between emacs.git and elpa.git?  GNU ELPA has
>>   hitherto pulled from dedicated branches on my upstream git repository.
>>   Maybe it would be better/easier to start building directly from the
>>   Emacs source?  This would reduce the overall workload.
>
> What does "start building directly from the Emacs source" mean here?

"Build" is the wrong term here.  Sorry about that!  My intent is to find
an easy way/workflow to get the files from Emacs into GNU ELPA.

And by "easy" I mean not to duplicate the work we do here.  So I would
not have to contact the GNU ELPA maintainers separately and have them
pull from my git source.

> FWIW, I don't think we should feel too bound to any particular process;
> this seems like a practical matter where we should try to do whatever
> is most practical.

Good to know.  I have no particular preference on the matter and shall
adapt to whatever you and others may recommend.

>> + Sending attachments with large diffs has the downside of losing the
>>   commit history.  Do Emacs maintainers wish to keep track of it?  If
>>   so, what would be the best way to preserve it, seeing as I am
>>   developing them on my own upstream?
>
> I don't think we generally worry about preserving history for packages
> managed externally.  We just sync the latest version.
>
> (If one really would like to preserve it, it could perhaps be done with
> some git magic.  I'm not sure it's worth the extra effort.)
Syncing the latest version works fine for me.

I have thus far published tagged releases on a monthly cadence.  Expect
the next one in mid to late November.

>> + Should the texinfo file be mentioned in the NEWS entry about the two
>>   themes?  The attached patch does not include such a change.
>
> We could of course add a NEWS entry for it.  Would you like to propose
> one?

I attach a possible rewording that also corrects "colour" and adds an
explicit reference to the WCAG AAA accessibility spec.  Please note that
I do not know how to properly reference an Info node: I used 'C-u 0 x',
which calls 'Info-copy-current-node-name'.

--
Protesilaos Stavrou
protesilaos.com

0001-Update-Modus-themes-NEWS-entry.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

Stefan Kangas-2
Protesilaos Stavrou <[hidden email]> writes:

> "Build" is the wrong term here.  Sorry about that!  My intent is to find
> an easy way/workflow to get the files from Emacs into GNU ELPA.
>
> And by "easy" I mean not to duplicate the work we do here.  So I would
> not have to contact the GNU ELPA maintainers separately and have them
> pull from my git source.

Right.  Hmm, it's a bit tricky to be honest, because there are several
options and AFAICT the workflows are not exactly 100 % streamlined in
all cases.  Maybe you could bring this question to emacs-devel?

> Syncing the latest version works fine for me.
>
> I have thus far published tagged releases on a monthly cadence.  Expect
> the next one in mid to late November.

Great.

> I attach a possible rewording that also corrects "colour" and adds an
> explicit reference to the WCAG AAA accessibility spec.  Please note that
> I do not know how to properly reference an Info node: I used 'C-u 0 x',
> which calls 'Info-copy-current-node-name'.

Great, thanks.  I made some minor changes and pushed it to master as
commit 00c4d982e8.



Reply | Threaded
Open this post in threaded view
|

bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

Protesilaos Stavrou
On 2020-10-17, 16:23 +0000, Stefan Kangas <[hidden email]> wrote:

> Protesilaos Stavrou <[hidden email]> writes:
>
>> "Build" is the wrong term here.  Sorry about that!  My intent is to find
>> an easy way/workflow to get the files from Emacs into GNU ELPA.
>>
>> And by "easy" I mean not to duplicate the work we do here.  So I would
>> not have to contact the GNU ELPA maintainers separately and have them
>> pull from my git source.
>
> Right.  Hmm, it's a bit tricky to be honest, because there are several
> options and AFAICT the workflows are not exactly 100 % streamlined in
> all cases.  Maybe you could bring this question to emacs-devel?

Yes, I shall post on emacs-devel.

>> I attach a possible rewording that also corrects "colour" and adds an
>> explicit reference to the WCAG AAA accessibility spec.  Please note that
>> I do not know how to properly reference an Info node: I used 'C-u 0 x',
>> which calls 'Info-copy-current-node-name'.
>
> Great, thanks.  I made some minor changes and pushed it to master as
> commit 00c4d982e8.

Thank you!

--
Protesilaos Stavrou
protesilaos.com



Reply | Threaded
Open this post in threaded view
|

bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

Stefan Kangas-2
Protesilaos Stavrou <[hidden email]> writes:

> Yes, I shall post on emacs-devel.

Excellent.  Do we have anything more to discuss in this bug report or
should it be closed?



Reply | Threaded
Open this post in threaded view
|

bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

Protesilaos Stavrou
On 2020-10-19, 14:18 +0200, Stefan Kangas <[hidden email]> wrote:

> Protesilaos Stavrou <[hidden email]> writes:
>
>> Yes, I shall post on emacs-devel.
>
> Excellent.  Do we have anything more to discuss in this bug report or
> should it be closed?

I did find some more references in the manual to package archives that
do not conform with the Emacs conventions.

Please give me some extra time while I prepare another patch (instead of
deferring it to the next release, as I had initially suggested).

--
Protesilaos Stavrou
protesilaos.com



Reply | Threaded
Open this post in threaded view
|

bug#43944: 28.0.50; Update modus-operandi, modus-vivendi themes to v0.13.0

Protesilaos Stavrou
On 2020-10-19, 15:31 +0300, Protesilaos Stavrou <[hidden email]> wrote:

> On 2020-10-19, 14:18 +0200, Stefan Kangas <[hidden email]> wrote:
>
>> Protesilaos Stavrou <[hidden email]> writes:
>>
>>> Yes, I shall post on emacs-devel.
>>
>> Excellent.  Do we have anything more to discuss in this bug report or
>> should it be closed?
>
> I did find some more references in the manual to package archives that
> do not conform with the Emacs conventions.
>
> Please give me some extra time while I prepare another patch (instead of
> deferring it to the next release, as I had initially suggested).
Please find attached the patch that should address the remaining issues
with the manual (in line with what was reported by Eli and Basil).  Once
it is merged, I think the bug report can be closed.

Note that I did not correct "greyscale" to "grayscale" because there is
a symbol involved.  This will definitely be changed ahead of the next
tagged release.

P.S. As always, feel free to amend the patch.  Thanks again!

--
Protesilaos Stavrou
protesilaos.com

0001-Fix-documentation-of-the-Modus-Themes.patch (10K) Download Attachment