bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error

Eli Zaretskii
> Date: Sat, 26 Sep 2020 08:31:19 -0700 (PDT)
> From: Drew Adams <[hidden email]>
> Cc: [hidden email], [hidden email]
>
> > You can see the code via the Git Web interface offered by Savannah's
> > Emacs page.  I provided a link several times in the past.
>
> If you post something here that I can use to
> replace the :enable code I showed, I'll be
> glad to try that and let you know what I see.

Sigh...  As mentioned several times before, please go to

  https://git.savannah.gnu.org/cgit/emacs.git

Click on "emacs-27", find my change from a few hours ago, click on its
line, and you will see the diffs.

(Can I convince you to bookmark that page, and use it henceforth when
you want to see some change installed in the repository?)



Reply | Threaded
Open this post in threaded view
|

bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error

Lars Ingebrigtsen
Eli Zaretskii <[hidden email]> writes:

> Sigh...  As mentioned several times before, please go to
>
>   https://git.savannah.gnu.org/cgit/emacs.git
>
> Click on "emacs-27", find my change from a few hours ago, click on its
> line, and you will see the diffs.

Good advice, but this reminds me of something that occurred to me some
time ago: Perhaps it would be nice if the script that sends out diff
emails also looked for text in the commit message that says "bug#4242"
and then Cc's [hidden email]?

It would be especially useful when doing bug triage on reopened bug
reports, where you could see what the patch applied was without going on
an archaeological expedition into git log, but also generally more
friendly towards bug reporters, who could then see the patch immediately
themselves.

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



Reply | Threaded
Open this post in threaded view
|

bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error

Drew Adams
In reply to this post by Eli Zaretskii
> > > You can see the code via the Git Web interface offered by Savannah's
> > > Emacs page.  I provided a link several times in the past.
> >
> > If you post something here that I can use to
> > replace the :enable code I showed, I'll be
> > glad to try that and let you know what I see.
>
> Sigh...  As mentioned several times before, please go to...
> Click on "emacs-27", find my change from a few hours ago, click on its
> line, and you will see the diffs.
> (Can I convince you to bookmark that page, and use it henceforth when
> you want to see some change installed in the repository?)

I think we're miscommunicating.  I didn't ask
to see your patch (diff).

I said that if you post here code I can use
to replace the :enable code I showed then I'll
be glad to help out by trying it and letting
you know what I see.  If you don't want to do
that, fine.

And thanks for patching, assuming the result
takes care of the problem discussed.  In that
case, when Emacs releases again (27.2?), with
the patch applied, Emacs will no longer present
the reported regression - the same :enable
will work for all Emacs releases (except 27.1).

In that case, the :enable condition will become:

(or (version= "27.1" emacs-version) ; bug #43569
    (not (condition-case nil
             (tags-loop-eval tags-loop-scan)
           (error t))))

so that the menu item is still enabled
unconditionally for the (presumably still)
broken 27.1.



Reply | Threaded
Open this post in threaded view
|

bug#43569: 28.0.50; Menu "Continue Tags Search" signals an error

Eli Zaretskii
> Date: Sat, 26 Sep 2020 09:31:43 -0700 (PDT)
> From: Drew Adams <[hidden email]>
> Cc: [hidden email], [hidden email]
>
> > Sigh...  As mentioned several times before, please go to...
> > Click on "emacs-27", find my change from a few hours ago, click on its
> > line, and you will see the diffs.
> > (Can I convince you to bookmark that page, and use it henceforth when
> > you want to see some change installed in the repository?)
>
> I think we're miscommunicating.  I didn't ask
> to see your patch (diff).
>
> I said that if you post here code I can use
> to replace the :enable code I showed then I'll
> be glad to help out by trying it and letting
> you know what I see.  If you don't want to do
> that, fine.

The patch shows the code, doesn't it?  So why do you insist on seeing
the code and not the change?