bug#42112: 27.0.91; whitespace-empty face not extended beyond EOL

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#42112: 27.0.91; whitespace-empty face not extended beyond EOL

Eli Zaretskii
> From: "Basil L. Contovounesios" <[hidden email]>
> Date: Sun, 28 Jun 2020 17:41:48 +0100
>
> 0. emacs -Q
> 1. M-x whitespace-mode RET
> 2. M-<
>
> In Emacs 26, line 3 is highlighted with the whitespace-empty face all
> the way to the right fringe.
>
> In Emacs 27, only the first two columns of line 3 are highlighted with
> the whitespace-empty face.
>
> Is this TRT?

I don't know: I don't use this mode.

> Should whitespace-empty get an ':extend t' attribute or inherit from
> some other face which already has that?

If we want the empty lines to be shown in this face in their entirety,
then it should have the :extend attribute, yes.  Just make sure it
looks OK with underline and other non-color attributes.



Reply | Threaded
Open this post in threaded view
|

bug#42112: 27.0.91; whitespace-empty face not extended beyond EOL

Basil L. Contovounesios
Eli Zaretskii <[hidden email]> writes:

>> From: "Basil L. Contovounesios" <[hidden email]>
>> Date: Sun, 28 Jun 2020 17:41:48 +0100
>>
>> 0. emacs -Q
>> 1. M-x whitespace-mode RET
>> 2. M-<
>>
>> In Emacs 26, line 3 is highlighted with the whitespace-empty face all
>> the way to the right fringe.
>>
>> In Emacs 27, only the first two columns of line 3 are highlighted with
>> the whitespace-empty face.
>>
>> Is this TRT?
>
> I don't know: I don't use this mode.

I do, but I'm not sure what constitutes correct behaviour.  I guess the
Emacs 26 behaviour is how the feature was designed and what users have
come to expect, in which case Emacs 27 exhibits a regression.

>> Should whitespace-empty get an ':extend t' attribute or inherit from
>> some other face which already has that?
>
> If we want the empty lines to be shown in this face in their entirety,
> then it should have the :extend attribute, yes.

Is there any practical difference or preference between giving
whitespace-empty an :extend attribute vs making it inherit from a face
with an :extend attribute?

> Just make sure it looks OK with underline and other non-color
> attributes.

Will do in about a week's time if no-one beats me to it.

Thanks,

--
Basil



Reply | Threaded
Open this post in threaded view
|

bug#42112: 27.0.91; whitespace-empty face not extended beyond EOL

Eli Zaretskii
> From: "Basil L. Contovounesios" <[hidden email]>
> Cc: [hidden email]
> Date: Sun, 28 Jun 2020 18:34:56 +0100
>
> Is there any practical difference or preference between giving
> whitespace-empty an :extend attribute vs making it inherit from a face
> with an :extend attribute?

Inheritance makes display slightly slower (due to the need to chase
the inheritance chain).  And frankly I don't see why we would need to
use inheritance here in the first place.