bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el

Doug Davis
When running `gnus' with a native compiled Emacs build a message is
reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
is called. I'm not sure what check is possible to see if a function is
natively compiled, but perhaps it should be added to this logic in
gnus.el:

  (unless (byte-code-function-p (symbol-function 'gnus))
    (message "You should byte-compile Gnus")
    (sit-for 2))



Reply | Threaded
Open this post in threaded view
|

bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el

arthur miller
Andrea Corallo <[hidden email]> writes:

> Doug Davis <[hidden email]> writes:
>
>> When running `gnus' with a native compiled Emacs build a message is
>> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
>> is called. I'm not sure what check is possible to see if a function is
>> natively compiled, but perhaps it should be added to this logic in
>> gnus.el:
>>
>>   (unless (byte-code-function-p (symbol-function 'gnus))
>>     (message "You should byte-compile Gnus")
>>     (sit-for 2))
>
> I'll admint that added to my undenaiable laziness I probably skiped this
> for so long cause was giving me a tiny satisfaction :)
>
> Should be fixed by:
>
> 801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
> compilation.
>
> Thanks for the feedback
>
>   Andrea
Just rebuild my Emacs and can confirm it if fixed.

Build time seems to be even faster (on my 67k i7 cpu with -j8 switch).

Awesome, thanks Andrea!



Reply | Threaded
Open this post in threaded view
|

bug#42010: 28.0.50; "You should byte-compile Gnus" message for natively compiled gnus.el

Andrea Corallo
Arthur Miller <[hidden email]> writes:

> Andrea Corallo <[hidden email]> writes:
>
>> Doug Davis <[hidden email]> writes:
>>
>>> When running `gnus' with a native compiled Emacs build a message is
>>> reported in the minibuffer "You should byte-compile Gnus" and `sit-for'
>>> is called. I'm not sure what check is possible to see if a function is
>>> natively compiled, but perhaps it should be added to this logic in
>>> gnus.el:
>>>
>>>   (unless (byte-code-function-p (symbol-function 'gnus))
>>>     (message "You should byte-compile Gnus")
>>>     (sit-for 2))
>>
>> I'll admint that added to my undenaiable laziness I probably skiped this
>> for so long cause was giving me a tiny satisfaction :)
>>
>> Should be fixed by:
>>
>> 801e19d0ba * lisp/gnus/gnus.el (gnus): Fix a check to handle native
>> compilation.
>>
>> Thanks for the feedback
>>
>>   Andrea
> Just rebuild my Emacs and can confirm it if fixed.
>
> Build time seems to be even faster (on my 67k i7 cpu with -j8 switch).
>
> Awesome, thanks Andrea!

Great, thank you for the testing :)

closing

  Andrea

--
[hidden email]