bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el

Theodor Thornhill
"Basil L. Contovounesios" <[hidden email]> writes:

> Since eshell-buffer-name is a variable, eval-when-compile is not the
> right thing to do here.  Instead, there should be a
> (defvar eshell-buffer-name) inside project-eshell declaring the symbol
> as special.  Right?

You are absolutely correct, and TIL - thanks :)

Below is another patch doing this. Works fine in emacs -Q


Theo


0001-Forward-declare-eshell-buffer-name-in-project-eshell.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el

Basil L. Contovounesios
Theodor Thornhill <[hidden email]> writes:

> "Basil L. Contovounesios" <[hidden email]> writes:
>
>> Since eshell-buffer-name is a variable, eval-when-compile is not the
>> right thing to do here.  Instead, there should be a
>> (defvar eshell-buffer-name) inside project-eshell declaring the symbol
>> as special.  Right?
>
> You are absolutely correct, and TIL - thanks :)
>
> Below is another patch doing this. Works fine in emacs -Q

Thanks, LGTM.

--
Basil



Reply | Threaded
Open this post in threaded view
|

bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el

Dmitry Gutov
On 21.06.2020 20:55, Basil L. Contovounesios wrote:
>> You are absolutely correct, and TIL - thanks:)
>>
>> Below is another patch doing this. Works fine in emacs -Q
> Thanks, LGTM.

Thanks all!

Pushed (after rephrasing the commit message in the imperative mood).



Reply | Threaded
Open this post in threaded view
|

bug#41977: 28.0.50; [PATCH]: eval-when-compile eshell in project.el

Basil L. Contovounesios
Dmitry Gutov <[hidden email]> writes:

> On 21.06.2020 20:55, Basil L. Contovounesios wrote:
>>> You are absolutely correct, and TIL - thanks:)
>>>
>>> Below is another patch doing this. Works fine in emacs -Q
>> Thanks, LGTM.
>
> Thanks all!
>
> Pushed (after rephrasing the commit message in the imperative mood).

In the future it should also be rephrased to include a reference to the
bug#number.  ;)

(Sorry, I didn't notice either.)

Thanks,

--
Basil