bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty

Stefan Kangas
Lars Ingebrigtsen <[hidden email]> writes:

> I don't think this is an ideal way to fix this command -- using error
> handling to do control flow is usually the wrong thing to do, and it
> makes debugging difficult.  What if there's a real bug in
> eww-bookmark-prepare?
>
> Instead eww-list-bookmarks should just do the
>
>   (eww-read-bookmarks)
>   (unless eww-bookmarks
>     (user-error "No bookmarks are defined"))
>
> bit, I think.  It might mean rearranging some stuff in eww-next-bookmark
> etc, though.
Thanks, good point.  Does the attached patch look better?

Best regards,
Stefan Kangas

0001-Show-eww-bookmarks-buffer-only-if-it-s-not-empty.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty

Lars Ingebrigtsen
Stefan Kangas <[hidden email]> writes:

> Thanks, good point.  Does the attached patch look better?

Yup; looks good to me.

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



Reply | Threaded
Open this post in threaded view
|

bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty

Lars Ingebrigtsen
Lars Ingebrigtsen <[hidden email]> writes:

> Stefan Kangas <[hidden email]> writes:
>
>> Thanks, good point.  Does the attached patch look better?
>
> Yup; looks good to me.

That was five weeks ago, and I'm triaging shr/eww bugs tonight, so I
went ahead and applied the patch.  :-)

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



Reply | Threaded
Open this post in threaded view
|

bug#41385: [PATCH] Show eww bookmarks buffer only if it's not empty

Stefan Kangas
Lars Ingebrigtsen <[hidden email]> writes:

> That was five weeks ago, and I'm triaging shr/eww bugs tonight, so I
> went ahead and applied the patch.  :-)

Thanks!