bug#41328: [PATCH] Declare some ancient compat aliases obsolete

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#41328: [PATCH] Declare some ancient compat aliases obsolete

Stefan Kangas-2
I found a series of old ancient backwards-compatilibity aliases that I
believe should be declare obsolete.  Most are from 2001-2004, but two
are from 1992 and 1993.

Does anyone have any objections to this?

Best regards,
Stefan Kangas

0001-Declare-some-ancient-compat-aliases-obsolete.patch (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#41328: [PATCH] Declare some ancient compat aliases obsolete

Basil L. Contovounesios
Stefan Kangas <[hidden email]> writes:

> I found a series of old ancient backwards-compatilibity aliases that I
> believe should be declare obsolete.  Most are from 2001-2004, but two
> are from 1992 and 1993.
>
> Does anyone have any objections to this?

No objections from me, just one question:

> diff --git a/lisp/progmodes/inf-lisp.el b/lisp/progmodes/inf-lisp.el
> index 9f34a377f4..7447c25fc0 100644
> --- a/lisp/progmodes/inf-lisp.el
> +++ b/lisp/progmodes/inf-lisp.el
> @@ -134,6 +134,7 @@ lisp-mode-map
>  ;;;  (with-eval-after-load 'inf-lisp 'inferior-lisp-install-letter-bindings)
>  ;;;You can modify this function to install just the bindings you want."
>  (defun inferior-lisp-install-letter-bindings ()
> +  (declare (obsolete nil "28.1"))
>    (define-key lisp-mode-map "\C-ce" 'lisp-eval-defun-and-go)
>    (define-key lisp-mode-map "\C-cr" 'lisp-eval-region-and-go)
>    (define-key lisp-mode-map "\C-cc" 'lisp-compile-defun-and-go)

What makes this an "ancient compat" or obsolete function?

Thanks,

--
Basil



Reply | Threaded
Open this post in threaded view
|

bug#41328: [PATCH] Declare some ancient compat aliases obsolete

Stefan Kangas-2
Basil L. Contovounesios <[hidden email]> writes:

> No objections from me, just one question:
>
> > diff --git a/lisp/progmodes/inf-lisp.el b/lisp/progmodes/inf-lisp.el
> > index 9f34a377f4..7447c25fc0 100644
> > --- a/lisp/progmodes/inf-lisp.el
> > +++ b/lisp/progmodes/inf-lisp.el
> > @@ -134,6 +134,7 @@ lisp-mode-map
> >  ;;;  (with-eval-after-load 'inf-lisp 'inferior-lisp-install-letter-bindings)
> >  ;;;You can modify this function to install just the bindings you want."
> >  (defun inferior-lisp-install-letter-bindings ()
> > +  (declare (obsolete nil "28.1"))
> >    (define-key lisp-mode-map "\C-ce" 'lisp-eval-defun-and-go)
> >    (define-key lisp-mode-map "\C-cr" 'lisp-eval-region-and-go)
> >    (define-key lisp-mode-map "\C-cc" 'lisp-compile-defun-and-go)
>
> What makes this an "ancient compat" or obsolete function?

Thanks for the review.  I initially had that impression from reading
the comments, but I have changed my mind since sending the patch.  I
think it's fair to say that some users might legitimately still use
it.  I'm therefore taking this part out.

Best regards,
Stefan Kangas



Reply | Threaded
Open this post in threaded view
|

bug#41328: [PATCH] Declare some ancient compat aliases obsolete

Stefan Kangas
close 41328 28.1
thanks

Stefan Kangas <[hidden email]> writes:

> Thanks for the review.  I initially had that impression from reading
> the comments, but I have changed my mind since sending the patch.  I
> think it's fair to say that some users might legitimately still use
> it.  I'm therefore taking this part out.

Now pushed to master with that change as commit 7899fa4309.

Best regards,
Stefan Kangas