bug#41095: ERC header line

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#41095: ERC header line

Philip K.

Hi,

when trying out a dark theme I noticed that the ERC header line was out
of place. It turns out that this is because it's fore- and background
color are hard-coded to gray20 and gray90. Since these are fairly
similar to the default colours of header-line using a light
colour-scheme, I suggest inheriting it's values by default.c

--
        Philip K.


From e5083ec06ee6a2be637fb8773a9c6cd907b26fc5 Mon Sep 17 00:00:00 2001
From: Philip K <[hidden email]>
Date: Tue, 5 May 2020 14:41:06 +0200
Subject: [PATCH] Make erc-header-line inherit from header-line

---
 lisp/erc/erc.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index cfde84e19a..a237ca7ce9 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1212,7 +1212,7 @@ erc-direct-msg-face
   :group 'erc-faces)
 
 (defface erc-header-line
-  '((t :foreground "grey20" :background "grey90"))
+  '((t :inherit header-line))
   "ERC face used for the header line.
 
 This will only be used if `erc-header-line-face-method' is non-nil."
--
2.20.1

Reply | Threaded
Open this post in threaded view
|

bug#41095: ERC header line

Lars Ingebrigtsen
[hidden email] (Philip K.) writes:

> when trying out a dark theme I noticed that the ERC header line was out
> of place. It turns out that this is because it's fore- and background
> color are hard-coded to gray20 and gray90. Since these are fairly
> similar to the default colours of header-line using a light
> colour-scheme, I suggest inheriting it's values by default.c

[...]

>  (defface erc-header-line
> -  '((t :foreground "grey20" :background "grey90"))
> +  '((t :inherit header-line))
>    "ERC face used for the header line.

This also makes the header line look less awkward in dark mode, so it
makes sense to me.  Applied to Emacs 28.

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no