bug#40003: 27.0.70; Windows build is without jansson support

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#40003: 27.0.70; Windows build is without jansson support

Ivan Yonchovski



The native json/serialization seems to be one of the important features
in the new upcomming 27 release. It will be great if the default GNU
Emacs windows build has it.



Reply | Threaded
Open this post in threaded view
|

bug#40003: 27.0.70; Windows build is without jansson support

Noam Postavsky
Eli Zaretskii <[hidden email]> writes:

>> From: Ivan Yonchovski <[hidden email]>
>> Date: Mon, 09 Mar 2020 21:53:58 +0200
>>
>> The native json/serialization seems to be one of the important features
>> in the new upcomming 27 release. It will be great if the default GNU
>> Emacs windows build has it.
>
> Phillip, are you looking into this?  I think I reported this a few
> weeks ago.

As far as I can tell, just the following would do the job:

--- i/admin/nt/dist-build/build-dep-zips.py
+++ w/admin/nt/dist-build/build-dep-zips.py
@@ -32,6 +32,7 @@
 PKG_REQ='''mingw-w64-x86_64-giflib
 mingw-w64-x86_64-gnutls
 mingw-w64-x86_64-harfbuzz
+mingw-w64-x86_64-jansson
 mingw-w64-x86_64-lcms2
 mingw-w64-x86_64-libjpeg-turbo
 mingw-w64-x86_64-libpng




Reply | Threaded
Open this post in threaded view
|

bug#40003: 27.0.70; Windows build is without jansson support

Ivan Yonchovski
Any update on this? 

On Tue, Apr 14, 2020 at 5:47 PM Noam Postavsky <[hidden email]> wrote:
Eli Zaretskii <[hidden email]> writes:

>> From: Ivan Yonchovski <[hidden email]>
>> Date: Mon, 09 Mar 2020 21:53:58 +0200
>>
>> The native json/serialization seems to be one of the important features
>> in the new upcomming 27 release. It will be great if the default GNU
>> Emacs windows build has it.
>
> Phillip, are you looking into this?  I think I reported this a few
> weeks ago.

As far as I can tell, just the following would do the job:

--- i/admin/nt/dist-build/build-dep-zips.py
+++ w/admin/nt/dist-build/build-dep-zips.py
@@ -32,6 +32,7 @@
 PKG_REQ='''mingw-w64-x86_64-giflib
 mingw-w64-x86_64-gnutls
 mingw-w64-x86_64-harfbuzz
+mingw-w64-x86_64-jansson
 mingw-w64-x86_64-lcms2
 mingw-w64-x86_64-libjpeg-turbo
 mingw-w64-x86_64-libpng

Reply | Threaded
Open this post in threaded view
|

bug#40003: 27.0.70; Windows build is without jansson support

Eli Zaretskii
In reply to this post by Noam Postavsky
> From: Phillip Lord <[hidden email]>
> Cc: Eli Zaretskii <[hidden email]>,  Ivan Yonchovski <[hidden email]>,
>   [hidden email]
> Date: Mon, 22 Jun 2020 16:53:25 +0100
>
> I am trying to build this against Emacs-28 at the moment. What test can
> I run on Emacs-28 to let me know if it has worked?

  cd test && make src/json-tests

If this says tests were not skipped, you've succeeded, and your Emacs
uses the libjansson library.

> After that, the decision is what to do for Emacs-27. I can add the
> dependency, but it will require rebuilding the deps file which will
> update *all* of the dependencies. Not a big problem in one sense, but we
> are in the pre-release test phase, IIUC.

I'd say go for it.  I don't expect trivial changes in the dependencies
to affect Emacs.

Thanks.



Reply | Threaded
Open this post in threaded view
|

bug#40003: 27.0.70; Windows build is without jansson support

Phillip Lord-3
Eli Zaretskii <[hidden email]> writes:

>> From: Phillip Lord <[hidden email]>
>> Cc: Eli Zaretskii <[hidden email]>,  Ivan Yonchovski <[hidden email]>,
>>   [hidden email]
>> Date: Mon, 22 Jun 2020 16:53:25 +0100
>>
>> I am trying to build this against Emacs-28 at the moment. What test can
>> I run on Emacs-28 to let me know if it has worked?
>
>   cd test && make src/json-tests
>
> If this says tests were not skipped, you've succeeded, and your Emacs
> uses the libjansson library.

Ah!

(fboundp 'json-serialize)



>> After that, the decision is what to do for Emacs-27. I can add the
>> dependency, but it will require rebuilding the deps file which will
>> update *all* of the dependencies. Not a big problem in one sense, but we
>> are in the pre-release test phase, IIUC.
>
> I'd say go for it.  I don't expect trivial changes in the dependencies
> to affect Emacs.


Okay. I've updated by deps files. Will have to wait for emacs-27.0.92 to
come out till the next upload.

Phil



Reply | Threaded
Open this post in threaded view
|

bug#40003: 27.0.70; Windows build is without jansson support

Phillip Lord-3
Phillip Lord <[hidden email]> writes:

>
> Ah!
>
> (fboundp 'json-serialize)
>
>
>
>>> After that, the decision is what to do for Emacs-27. I can add the
>>> dependency, but it will require rebuilding the deps file which will
>>> update *all* of the dependencies. Not a big problem in one sense, but we
>>> are in the pre-release test phase, IIUC.
>>
>> I'd say go for it.  I don't expect trivial changes in the dependencies
>> to affect Emacs.
>
>
> Okay. I've updated by deps files. Will have to wait for emacs-27.0.92 to
> come out till the next upload.


I have pushed a snapshot release of emacs-28 to alpha which contains
this support as far as I can tell. "As far as I can tell" means

(fboundp 'json-serialize)

so any slightly more rigourous testing of this build against a real
world use case would be appreciated.

https://alpha.gnu.org/gnu/emacs/pretest/windows/emacs-28/


Phil



Reply | Threaded
Open this post in threaded view
|

bug#40003: 27.0.70; Windows build is without jansson support

Eli Zaretskii
> From: Phillip Lord <[hidden email]>
> Cc: [hidden email],  [hidden email],  [hidden email]
> Date: Tue, 30 Jun 2020 12:13:05 +0100
>
> I have pushed a snapshot release of emacs-28 to alpha which contains
> this support as far as I can tell.

Thanks.

> "As far as I can tell" means
>
> (fboundp 'json-serialize)
>
> so any slightly more rigourous testing of this build against a real
> world use case would be appreciated.

There's a small test suite in test/src/json-tests.el.



Reply | Threaded
Open this post in threaded view
|

bug#40003: 27.0.70; Windows build is without jansson support

Phillip Lord-3
On 2020-06-30 15:26, Eli Zaretskii wrote:

>> From: Phillip Lord <[hidden email]>
>> Cc: [hidden email],  [hidden email],  [hidden email]
>> Date: Tue, 30 Jun 2020 12:13:05 +0100
>>
>> I have pushed a snapshot release of emacs-28 to alpha which contains
>> this support as far as I can tell.
>
> Thanks.
>
>> "As far as I can tell" means
>>
>> (fboundp 'json-serialize)
>>
>> so any slightly more rigourous testing of this build against a real
>> world use case would be appreciated.
>
> There's a small test suite in test/src/json-tests.el.

Yes, I know, but the test suite tests the build and not the packaged
version. We don't have any way to check that automatically.



Reply | Threaded
Open this post in threaded view
|

bug#40003: 27.0.70; Windows build is without jansson support

Ivan Yonchovski
FWIW a few lsp-mode users tested the build and it works as expected.

Thanks,
Ivan

On Tue, Jun 30, 2020 at 11:56 PM <[hidden email]> wrote:
On 2020-06-30 15:26, Eli Zaretskii wrote:
>> From: Phillip Lord <[hidden email]>
>> Cc: [hidden email][hidden email][hidden email]
>> Date: Tue, 30 Jun 2020 12:13:05 +0100
>>
>> I have pushed a snapshot release of emacs-28 to alpha which contains
>> this support as far as I can tell.
>
> Thanks.
>
>> "As far as I can tell" means
>>
>> (fboundp 'json-serialize)
>>
>> so any slightly more rigourous testing of this build against a real
>> world use case would be appreciated.
>
> There's a small test suite in test/src/json-tests.el.

Yes, I know, but the test suite tests the build and not the packaged
version. We don't have any way to check that automatically.
Reply | Threaded
Open this post in threaded view
|

bug#40003: 27.0.70; Windows build is without jansson support

Phillip Lord-3


It's worth a lot! Thanks for the info.

Phil

yyoncho <[hidden email]> writes:

> FWIW a few lsp-mode users tested the build and it works as expected.
>
> Thanks,
> Ivan
>
> On Tue, Jun 30, 2020 at 11:56 PM <[hidden email]> wrote:
>
>> On 2020-06-30 15:26, Eli Zaretskii wrote:
>> >> From: Phillip Lord <[hidden email]>
>> >> Cc: [hidden email],  [hidden email],  [hidden email]
>> >> Date: Tue, 30 Jun 2020 12:13:05 +0100
>> >>
>> >> I have pushed a snapshot release of emacs-28 to alpha which contains
>> >> this support as far as I can tell.
>> >
>> > Thanks.
>> >
>> >> "As far as I can tell" means
>> >>
>> >> (fboundp 'json-serialize)
>> >>
>> >> so any slightly more rigourous testing of this build against a real
>> >> world use case would be appreciated.
>> >
>> > There's a small test suite in test/src/json-tests.el.
>>
>> Yes, I know, but the test suite tests the build and not the packaged
>> version. We don't have any way to check that automatically.
>>