bug#39168: 27.0.50; Error on command line flags with use dump-file flag with other flags

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#39168: 27.0.50; Error on command line flags with use dump-file flag with other flags

Eli Zaretskii
> From: Yuan Fu <[hidden email]>
> Date: Fri, 24 Apr 2020 11:58:05 -0400
> Cc: [hidden email]
>
> I’m still seeing this in the latest master build. Could you give me some
> pointers on how to fix this?

I thought I did just that in

  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=39168#8

Do you have follow-up questions?



Reply | Threaded
Open this post in threaded view
|

bug#39168: 27.0.50; Error on command line flags with use dump-file flag with other flags

Yuan Fu


> On Apr 24, 2020, at 12:31 PM, Eli Zaretskii <[hidden email]> wrote:
>
>> From: Yuan Fu <[hidden email]>
>> Date: Fri, 24 Apr 2020 11:58:05 -0400
>> Cc: [hidden email]
>>
>> I’m still seeing this in the latest master build. Could you give me some
>> pointers on how to fix this?
>
> I thought I did just that in
>
>  https://nam01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdebbugs.gnu.org%2Fcgi%2Fbugreport.cgi%3Fbug%3D39168%238&amp;data=02%7C01%7Cykf5041%40psu.edu%7C73225549a67c47daa17708d7e86d09d7%7C7cf48d453ddb4389a9c1c115526eb52e%7C0%7C0%7C637233427328246054&amp;sdata=NKZV6igzz0KyKIbM%2Fla8f4DPb7quGe2CdV1aA%2FqSSdA%3D&amp;reserved=0
>
> Do you have follow-up questions?

Ah, yes. How can I check if Emacs is restored from a portable dump file? I see strcmp (temacs, "pdump”) in main but I don’t think that’s in scope in init_cmdargs. Thanks.

Yuan


Reply | Threaded
Open this post in threaded view
|

bug#39168: 27.0.50; Error on command line flags with use dump-file flag with other flags

Eli Zaretskii
> From: Yuan Fu <[hidden email]>
> Date: Fri, 24 Apr 2020 13:45:51 -0400
> Cc: [hidden email]
>
> > Do you have follow-up questions?
>
> Ah, yes. How can I check if Emacs is restored from a portable dump file?

One way is to use the function pdumper-stats.



Reply | Threaded
Open this post in threaded view
|

bug#39168: 27.0.50; Error on command line flags with use dump-file flag with other flags

Yuan Fu


> On Apr 24, 2020, at 2:05 PM, Eli Zaretskii <[hidden email]> wrote:
>
>> From: Yuan Fu <[hidden email]>
>> Date: Fri, 24 Apr 2020 13:45:51 -0400
>> Cc: [hidden email]
>>
>>> Do you have follow-up questions?
>>
>> Ah, yes. How can I check if Emacs is restored from a portable dump file?
>
> One way is to use the function pdumper-stats.

Thinking more about it, maybe I shouldn’t check if Emacs is restored from a portable dump file, since having “—dump-file” in argv should mean that Emacs is restored from a portable dump file anyway.

Yuan


Reply | Threaded
Open this post in threaded view
|

bug#39168: 27.0.50; Error on command line flags with use dump-file flag with other flags

Yuan Fu
Here is my first attempt. The implementation of argmatch gives me an impression that when the flag only have one dash, you are not supposed to add “=“ after it. IOW, -dump-file=xxx is a misuse. BTW, I don’t see a test for emacs startup in /test/src. Are there test cases that I should test against?


dump-file.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#39168: 27.0.50; Error on command line flags with use dump-file flag with other flags

Yuan Fu
I almost forgot about this, any updates?

Yuan

> On Apr 24, 2020, at 4:24 PM, Yuan Fu <[hidden email]> wrote:
>
> Here is my first attempt. The implementation of argmatch gives me an impression that when the flag only have one dash, you are not supposed to add “=“ after it. IOW, -dump-file=xxx is a misuse. BTW, I don’t see a test for emacs startup in /test/src. Are there test cases that I should test against?
>
> <dump-file.patch>