bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el

Stefan Kangas
This patch fixes these warnings in make check:

  ELC      src/undo-tests.elc

In toplevel form:
src/undo-tests.el:262:6:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.
src/undo-tests.el:317:6:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.
src/undo-tests.el:353:47:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.
src/undo-tests.el:370:13:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.
src/undo-tests.el:394:19:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.
src/undo-tests.el:433:11:Warning: `delete-forward-char' is for interactive use
    only; use `delete-char' instead.

(I'll send the patch in a separate message once this is assigned a bug
number.)

Thanks,
Stefan Kangas



Reply | Threaded
Open this post in threaded view
|

bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el

Stefan Kangas
Stefan Kangas <[hidden email]> writes:
> (I'll send the patch in a separate message once this is assigned a bug
> number.)

Patch attached.

Thanks,
Stefan Kangas

0001-Suppress-interactive-only-warnings-in-undo-tests.el.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el

Stefan Kangas
Stefan Kangas <[hidden email]> writes:
>
> Stefan Kangas <[hidden email]> writes:
> > (I'll send the patch in a separate message once this is assigned a bug
> > number.)
>
> Patch attached.

1. Wrong patch attached, ugh.  Please find correct version attached.

2. This actually doesn't work due to an issue with with-suppressed-tests.
I have reported a separate Bug#36568 for this.

This patch therefore unfortunately would have no effect for now.

Thanks,
Stefan Kangas

0001-Suppress-interactive-only-warnings-in-undo-tests.el.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el

Stefan Kangas
Correct patch attached -- third attempt.

(Sorry about the noise -- it was created in the "test" subdirectory
and I mixed it up.)

0001-Suppress-interactive-only-warnings-in-undo-tests.el-.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el

Lars Ingebrigtsen
In reply to this post by Stefan Kangas
Stefan Kangas <[hidden email]> writes:

> This patch fixes these warnings in make check:
>
>   ELC      src/undo-tests.elc
>
> In toplevel form:
> src/undo-tests.el:262:6:Warning: `delete-forward-char' is for interactive use
>     only; use `delete-char' instead.

Hm...  is it worth it to suppress warnings in the tests, though?  I
think we kinda expect there to be a lot of noise when running the tests?

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



Reply | Threaded
Open this post in threaded view
|

bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el

Stefan Kangas
Lars Ingebrigtsen <[hidden email]> writes:
> Hm...  is it worth it to suppress warnings in the tests, though?  I
> think we kinda expect there to be a lot of noise when running the tests?

I'm not sure I understand.  Do you mean that you're not sure if it's
worth it to fix warnings in the Emacs test suite, or do you mean
fixing with-suppressed-warnings to handle this case?

Best regards,
Stefan Kangas



Reply | Threaded
Open this post in threaded view
|

bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el

Lars Ingebrigtsen
Stefan Kangas <[hidden email]> writes:

> Lars Ingebrigtsen <[hidden email]> writes:
>> Hm...  is it worth it to suppress warnings in the tests, though?  I
>> think we kinda expect there to be a lot of noise when running the tests?
>
> I'm not sure I understand.  Do you mean that you're not sure if it's
> worth it to fix warnings in the Emacs test suite, or do you mean
> fixing with-suppressed-warnings to handle this case?

I meant the first.  I mean, I'm not opposed to it or anything, but my
opinion is that aiming for a warning-free test suite would be to put
an undue burden on the test writers for little gain.  (When we're used
to having a warning-free build, then any warning sticks out like a sore
thumb and is generally fixed pretty quickly...)

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



Reply | Threaded
Open this post in threaded view
|

bug#36565: [PATCH] Suppress interactive-only warnings in undo-tests.el

Stefan Kangas
Lars Ingebrigtsen <[hidden email]> writes:

> I mean, I'm not opposed to it or anything, but my
> opinion is that aiming for a warning-free test suite would be to put
> an undue burden on the test writers for little gain.

Thanks for clarifying, and I fully agree.

Best regards,
Stefan Kangas