bug#35491: Subject: 27.0.50; word-at-point, hand over optional argument

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#35491: Subject: 27.0.50; word-at-point, hand over optional argument

Andreas Röhler
Hi,

please permit ‘word-at-point’ to hand over optional arg ‘no-properties’

‘thing-at-point’ comes with an optional argument ‘no-properties’.
Seems there is no way to set it from calling ‘word-at-point’.

With attached patch:

(setq a (word-at-point t))foo

a ==> "foo"

;; current constraint:
(setq b (word-at-point))foo

b ==> #("foo" 0 2 (fontified t) 2 3 (fontified t rear-nonsticky t))

;;;



In GNU Emacs 27.0.50 (build 1, i686-pc-linux-gnu, GTK+ Version 3.14.5)
  of 2019-04-29
Repository revision: 74712470fcb95cd4ef6ef5c61eee73cb8e02a8bd
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.11604000
System Description: Debian GNU/Linux 8 (jessie)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Type C-x 1 to delete the help window.
mouse-2, RET: find function's definition
Type C-x 1 to delete the help window, C-M-v to scroll help.
mouse-2, RET: find function's definition
Mark set

Configured using:
  'configure --with-modules --with-mailutils'

Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL
GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM
MODULES THREADS PDUMPER GMP

Important settings:
   value of $LANG: de_DE.utf8
   locale-coding-system: utf-8-unix

Major mode: Emacs-Lisp

Minor modes in effect:
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t
   line-number-mode: t
   transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny seq byte-opt gv
bytecomp byte-compile cconv dired dired-loaddefs format-spec rfc822 mml
mml-sec password-cache epa derived epg epg-config gnus-util rmail
rmail-loaddefs text-property-search time-date mm-decode mm-bodies
mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils vc-git
diff-mode easy-mmode find-func cl-extra thingatpt help-fns radix-tree
help-mode easymenu cl-loaddefs cl-lib elec-pair mule-util tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win
x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote threads dbusbind inotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 8 144321 10677)
  (symbols 24 28536 1)
  (strings 16 63330 2694)
  (string-bytes 1 987604)
  (vectors 8 10126)
  (vector-slots 4 128792 17668)
  (floats 8 22 34)
  (intervals 28 376 12)
  (buffers 564 13)
  (heap 1024 11153 876))


word-at-point.patch (493 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#35491: Subject: 27.0.50; word-at-point, hand over optional argument

Noam Postavsky
Andreas Röhler <[hidden email]> writes:

> please permit ‘word-at-point’ to hand over optional arg ‘no-properties’
>
> ‘thing-at-point’ comes with an optional argument ‘no-properties’.
> Seems there is no way to set it from calling ‘word-at-point’.
>
> With attached patch:
>
> (setq a (word-at-point t))foo
>
> a ==> "foo"
>
> ;; current constraint:
> (setq b (word-at-point))foo
>
> b ==> #("foo" 0 2 (fontified t) 2 3 (fontified t rear-nonsticky t))
Sure, I guess there's no reason not to.  Any problems with the patch
below?  (I avoided looking at yours since I recall you have some
philosophical/legal objection to signing copyright papers)


From e04036fd70a5c147831f54c18f51f244c22f6291 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <[hidden email]>
Date: Tue, 7 May 2019 18:15:35 -0400
Subject: [PATCH] Accept NO-PROPERTIES in thing-at-point aliases (Bug#35491)

* lisp/thingatpt.el (word-at-point, sentence-at-point): Accept and
pass NO-PROPERTIES to thing-at-point.
* etc/NEWS: Announce change.
---
 etc/NEWS          | 9 ++++++++-
 lisp/thingatpt.el | 8 ++++----
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 9e3559d27e..d8e5cbdd09 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1247,11 +1247,18 @@ automatically updates.  In the buffer, you can use 's q' or 's e' to
 signal a thread with quit or error respectively, or get a snapshot
 backtrace with 'b'.
 
+
+** thingatpt.el
+
 ---
-** thingatpt.el supports a new "thing" called 'uuid'.
+*** 'thing-at-point' supports a new "thing" called 'uuid'.
 A symbol 'uuid' can be passed to 'thing-at-point' and it returns the
 UUID at point.
 
+---
+*** 'word-at-point' and 'sentence-at-point' accept NO-PROPERTIES.
+Just like 'thing-at-point' itself.
+
 ** Interactive automatic highlighting
 
 +++
diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
index 26e084320b..60a20e2d18 100644
--- a/lisp/thingatpt.el
+++ b/lisp/thingatpt.el
@@ -585,13 +585,13 @@ (put 'uuid 'bounds-of-thing-at-point
 
 ;;  Aliases
 
-(defun word-at-point ()
+(defun word-at-point (&optional no-properties)
   "Return the word at point.  See `thing-at-point'."
-  (thing-at-point 'word))
+  (thing-at-point 'word no-properties))
 
-(defun sentence-at-point ()
+(defun sentence-at-point (&optional no-properties)
   "Return the sentence at point.  See `thing-at-point'."
-  (thing-at-point 'sentence))
+  (thing-at-point 'sentence no-properties))
 
 (defun thing-at-point--read-from-whole-string (str)
   "Read a Lisp expression from STR.
--
2.11.0

Reply | Threaded
Open this post in threaded view
|

bug#35491: Subject: 27.0.50; word-at-point, hand over optional argument

Andreas Röhler

On 08.05.19 00:20, Noam Postavsky wrote:

> Andreas Röhler <[hidden email]> writes:
>
>> please permit ‘word-at-point’ to hand over optional arg ‘no-properties’
>>
>> ‘thing-at-point’ comes with an optional argument ‘no-properties’.
>> Seems there is no way to set it from calling ‘word-at-point’.
>>
>> With attached patch:
>>
>> (setq a (word-at-point t))foo
>>
>> a ==> "foo"
>>
>> ;; current constraint:
>> (setq b (word-at-point))foo
>>
>> b ==> #("foo" 0 2 (fontified t) 2 3 (fontified t rear-nonsticky t))
> Sure, I guess there's no reason not to.  Any problems with the patch
> below?  (I avoided looking at yours since I recall you have some
> philosophical/legal objection to signing copyright papers)
>
Looks good for me, thanks considering related cases too.





Reply | Threaded
Open this post in threaded view
|

bug#35491: Subject: 27.0.50; word-at-point, hand over optional argument

Noam Postavsky
tags 35491 fixed
close 35491 27.1
quit

Andreas Röhler <[hidden email]> writes:

> Looks good for me, thanks considering related cases too.

Pushed to master.

04e9938350 2019-05-16T06:53:05-04:00 "Accept NO-PROPERTIES in thing-at-point aliases (Bug#35491)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=04e9938350d3820648d28d7cf4aa1885a08fd9b7