bug#34756: 26.1.92; Minor typos across manuals

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#34756: 26.1.92; Minor typos across manuals

Basil L. Contovounesios
Severity: minor
Tags: patch



Are the three attached patches acceptable for the emacs-26 branch?
If so, should I add this bug number to all or none of them?

Thanks,

--
Basil

In GNU Emacs 26.1.92 (build 5, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-03-05 built on thunk
Repository revision: 52fd40068e0f8b41bd29eaec1334299eb86d0bff
Windowing system distributor 'The X.Org Foundation', version 11.0.12003000
System Description: Debian GNU/Linux buster/sid

0001-Fix-some-plural-Message-IDs-typos-in-Gnus-docs.patch (2K) Download Attachment
0002-Fix-possessive-it-s-its-typos-in-manuals.patch (4K) Download Attachment
0003-Fix-an-other-another-typos-in-manuals.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#34756: 26.1.92; Minor typos across manuals

Eli Zaretskii
> From: "Basil L. Contovounesios" <[hidden email]>
> Date: Tue, 05 Mar 2019 08:41:21 +0000
>
> Are the three attached patches acceptable for the emacs-26 branch?

Documentation changes should always go to the release branch, unless
they document features only available on master.

> If so, should I add this bug number to all or none of them?

It's okay to push all of them under the same bug number, and even in a
single commit.  There's no need to distinguish between changes that
correct typos, they are all "alike" for all practical purposes.

Thanks.



Reply | Threaded
Open this post in threaded view
|

bug#34756: 26.1.92; Minor typos across manuals

Basil L. Contovounesios
fixed 34756 26.2
quit

Eli Zaretskii <[hidden email]> writes:

>> From: "Basil L. Contovounesios" <[hidden email]>
>> Date: Tue, 05 Mar 2019 08:41:21 +0000
>>
>> Are the three attached patches acceptable for the emacs-26 branch?
>
> Documentation changes should always go to the release branch, unless
> they document features only available on master.
>
>> If so, should I add this bug number to all or none of them?
>
> It's okay to push all of them under the same bug number, and even in a
> single commit.  There's no need to distinguish between changes that
> correct typos, they are all "alike" for all practical purposes.

Thanks for clarifying, I've now pushed to the release branch.  Let me
know if anything is amiss, e.g. if signed commits are frowned upon.

--
Basil



Reply | Threaded
Open this post in threaded view
|

bug#34756: 26.1.92; Minor typos across manuals

Basil L. Contovounesios
"Basil L. Contovounesios" <[hidden email]> writes:

> Thanks for clarifying, I've now pushed to the release branch.  Let me
> know if anything is amiss, e.g. if signed commits are frowned upon.

Ugh, I got the Changelog format slightly wrong.  Sorry about that.

--
Basil



Reply | Threaded
Open this post in threaded view
|

bug#34756: 26.1.92; Minor typos across manuals

Eli Zaretskii
In reply to this post by Basil L. Contovounesios
> From: "Basil L. Contovounesios" <[hidden email]>
> Cc: <[hidden email]>
> Date: Tue, 05 Mar 2019 20:44:12 +0000
>
> if signed commits are frowned upon.

They are; see CONTRIBUTE.



Reply | Threaded
Open this post in threaded view
|

bug#34756: 26.1.92; Minor typos across manuals

Eli Zaretskii
In reply to this post by Basil L. Contovounesios
> From: "Basil L. Contovounesios" <[hidden email]>
> Cc: <[hidden email]>
> Date: Tue, 05 Mar 2019 20:48:16 +0000
>
> Ugh, I got the Changelog format slightly wrong.

You did?  Where?



Reply | Threaded
Open this post in threaded view
|

bug#34756: 26.1.92; Minor typos across manuals

Basil L. Contovounesios
In reply to this post by Eli Zaretskii
Eli Zaretskii <[hidden email]> writes:

>> From: "Basil L. Contovounesios" <[hidden email]>
>> Cc: <[hidden email]>
>> Date: Tue, 05 Mar 2019 20:44:12 +0000
>>
>> if signed commits are frowned upon.
>
> They are; see CONTRIBUTE.

I checked CONTRIBUTE, but I only saw mention of "Signed-off-by:" lines,
not GPG signing.  Is the latter also unwelcome?  I assumed not, given
the existence of a Project Member GPG Keyring on Savannah.

--
Basil



Reply | Threaded
Open this post in threaded view
|

bug#34756: 26.1.92; Minor typos across manuals

Basil L. Contovounesios
In reply to this post by Eli Zaretskii
Eli Zaretskii <[hidden email]> writes:

>> From: "Basil L. Contovounesios" <[hidden email]>
>> Cc: <[hidden email]>
>> Date: Tue, 05 Mar 2019 20:48:16 +0000
>>
>> Ugh, I got the Changelog format slightly wrong.
>
> You did?  Where?

I forgot to denote file names with a leading asterisk:
http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=099ef446c2c1014727cfe98268fe468eb2e8828b

--
Basil



Reply | Threaded
Open this post in threaded view
|

bug#34756: 26.1.92; Minor typos across manuals

Eli Zaretskii
In reply to this post by Basil L. Contovounesios
> From: "Basil L. Contovounesios" <[hidden email]>
> Cc: <[hidden email]>
> Date: Wed, 13 Mar 2019 17:31:02 +0000
>
> Eli Zaretskii <[hidden email]> writes:
>
> >> From: "Basil L. Contovounesios" <[hidden email]>
> >> Cc: <[hidden email]>
> >> Date: Tue, 05 Mar 2019 20:44:12 +0000
> >>
> >> if signed commits are frowned upon.
> >
> > They are; see CONTRIBUTE.
>
> I checked CONTRIBUTE, but I only saw mention of "Signed-off-by:" lines,
> not GPG signing.

Well, you didn't really explain what you meant by "signed commits".

> Is the latter also unwelcome?  I assumed not, given the existence of
> a Project Member GPG Keyring on Savannah.

I don't think this was ever discussed.  Are there any GPG signed
commits in the repository?



Reply | Threaded
Open this post in threaded view
|

bug#34756: 26.1.92; Minor typos across manuals

Basil L. Contovounesios
In reply to this post by Basil L. Contovounesios
Eli Zaretskii <[hidden email]> writes:

>> From: "Basil L. Contovounesios" <[hidden email]>
>> Cc: <[hidden email]>
>> Date: Wed, 13 Mar 2019 17:31:02 +0000
>>
>> Eli Zaretskii <[hidden email]> writes:
>>
>> >> From: "Basil L. Contovounesios" <[hidden email]>
>> >> Cc: <[hidden email]>
>> >> Date: Tue, 05 Mar 2019 20:44:12 +0000
>> >>
>> >> if signed commits are frowned upon.
>> >
>> > They are; see CONTRIBUTE.
>>
>> I checked CONTRIBUTE, but I only saw mention of "Signed-off-by:" lines,
>> not GPG signing.
>
> Well, you didn't really explain what you meant by "signed commits".

True; sorry about that.

>> Is the latter also unwelcome?  I assumed not, given the existence of
>> a Project Member GPG Keyring on Savannah.
>
> I don't think this was ever discussed.  Are there any GPG signed
> commits in the repository?

Yes, predominantly those of Nicolas Petton.  I listed them thusly:
git log --since=2018-01-01 --format='%h %aI %GS' | awk 'NF>2'

--
Basil