bug#34323: reproducibility: absolute file names in ox-odt.elc

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#34323: reproducibility: absolute file names in ox-odt.elc

Glenn Morris-3
Package: emacs,org-mode
Version: 26.1.91
Severity: minor

The compiled file ox-odt.elc contains strings that refer to the
absolute location of the build directory, through
org-odt-schema-dir-list and org-odt-styles-dir-list.
For example, in the Emacs 26.1.91 pretest tarfile, it contains
"/home/nico/work/emacs-26/etc/schema/" and
"/home/nico/work/emacs-26/etc/styles/".
This means the generated elc file is non-reproducible (ie, the contents
change depending on the build directory).

(Like https://debbugs.gnu.org/34321, issued spotted in
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/emacs.html
)



Reply | Threaded
Open this post in threaded view
|

bug#34323: reproducibility: absolute file names in ox-odt.elc

Nicolas Goaziou-3
Hello,

Glenn Morris <[hidden email]> writes:

> Package: emacs,org-mode
> Version: 26.1.91
> Severity: minor
>
> The compiled file ox-odt.elc contains strings that refer to the
> absolute location of the build directory, through
> org-odt-schema-dir-list and org-odt-styles-dir-list.
> For example, in the Emacs 26.1.91 pretest tarfile, it contains
> "/home/nico/work/emacs-26/etc/schema/" and
> "/home/nico/work/emacs-26/etc/styles/".
> This means the generated elc file is non-reproducible (ie, the contents
> change depending on the build directory).
>
> (Like https://debbugs.gnu.org/34321, issued spotted in
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/emacs.html
> )

I'm Cc'ing the author of ox-odt.el as he might have more insight.

Regards,

--
Nicolas Goaziou



Reply | Threaded
Open this post in threaded view
|

bug#34323: reproducibility: absolute file names in ox-odt.elc

Glenn Morris-3
In reply to this post by Glenn Morris-3

It's due to the eval-when-compile sections in org-odt-schema-dir-list
and org-odt-styles-dir-list. These don't make sense to me. All they do
is add the build directory. There is a comment "see make install", but I
cannot see what this refers to. No similar variable initializes itself
in this way AFAIK. If those sections are removed, does anything stop
working?



Reply | Threaded
Open this post in threaded view
|

bug#34323: reproducibility: absolute file names in ox-odt.elc

Nicolas Goaziou-3
Hello,

Glenn Morris <[hidden email]> writes:

> It's due to the eval-when-compile sections in org-odt-schema-dir-list
> and org-odt-styles-dir-list. These don't make sense to me. All they do
> is add the build directory. There is a comment "see make install", but I
> cannot see what this refers to. No similar variable initializes itself
> in this way AFAIK. If those sections are removed, does anything stop
> working?

I don't know. I removed `the `eval-when-compile' calls. We'll see what
horrible things happen.

I'm closing this bug for now. Thank you for reporting it.

Regards,

--
Nicolas Goaziou