bug#34305: [PATCH] Add switches to hg revert

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#34305: [PATCH] Add switches to hg revert

Ian Dunn

* vc/vc-hg.el (vc-hg-revert-switches): New user variable.
  (vc-hg-revert): Use switches for revert.



--
Ian Dunn

vc-hg.el.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#34305: [PATCH] Add switches to hg revert

Eli Zaretskii
> From: Ian Dunn <[hidden email]>
> Date: Sun, 03 Feb 2019 21:55:50 -0500
>
> * vc/vc-hg.el (vc-hg-revert-switches): New user variable.
>   (vc-hg-revert): Use switches for revert.

Thanks.  Please also include an announcement of this in NEWS.



Reply | Threaded
Open this post in threaded view
|

bug#34305: [PATCH] Add switches to hg revert

Ian Dunn
Does this work?

*** New user option 'vc-hg-revert-switches' specifies switches to pass
to hg revert.

On February 4, 2019 11:54:03 AM EST, Eli Zaretskii <[hidden email]> wrote:
From: Ian Dunn <[hidden email]>
Date: Sun, 03 Feb 2019 21:55:50 -0500

* vc/vc-hg.el (vc-hg-revert-switches): New user variable.
(vc-hg-revert): Use switches for revert.

Thanks. Please also include an announcement of this in NEWS.


--
Ian Dunn
Reply | Threaded
Open this post in threaded view
|

bug#34305: [PATCH] Add switches to hg revert

Dmitry Gutov
In reply to this post by Ian Dunn
On 04.02.2019 05:55, Ian Dunn wrote:
> +  ;; No nil option, since there's no `vc-revert-switches' variable.

nil should still work (vc-switches checks whether vc-revert-switches is
bound, it's not an error), and it would probably be more intuitive.



Reply | Threaded
Open this post in threaded view
|

bug#34305: [PATCH] Add switches to hg revert

Ian Dunn

    DG> On 04.02.2019 05:55, Ian Dunn wrote:
    >> +  ;; No nil option, since there's no `vc-revert-switches' variable.

    DG> nil should still work (vc-switches checks whether vc-revert-switches is bound,
    DG> it's not an error), and it would probably be more intuitive.

I see your point.  `vc-bzr-log-switches' does this as well.  I've updated the patch to use nil instead of t.



--
Ian Dunn

vc-hg.el.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#34305: [PATCH] Add switches to hg revert

Dmitry Gutov
On 07.02.2019 04:42, Ian Dunn wrote:
>
>      DG> On 04.02.2019 05:55, Ian Dunn wrote:
>      >> +  ;; No nil option, since there's no `vc-revert-switches' variable.
>
>      DG> nil should still work (vc-switches checks whether vc-revert-switches is bound,
>      DG> it's not an error), and it would probably be more intuitive.
>
> I see your point.  `vc-bzr-log-switches' does this as well.  I've updated the patch to use nil instead of t.

Pushed, thank you.