bug#33021: nsterm.m: missing two (2) closing parentheses ...

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#33021: nsterm.m: missing two (2) closing parentheses ...

Keith David Bershatsky
At the convenience of the Emacs team, please add two (2) closing parentheses to nsterm.m.  While it is possible to build Emacs, working on the functions is difficult because Emacs cannot narrow properly to a defun ....  Thanks.

      if ([child parentWindow] != nil)
        {
          [[child parentWindow] removeChildWindow:child];
#if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 101000
#if MAC_OS_X_VERSION_MIN_REQUIRED < 101000

/* *** HERE *** */

          if ([child respondsToSelector:@selector(setAccessibilitySubrole:)]
#endif
              [child setAccessibilitySubrole:NSAccessibilityStandardWindowSubrole];
#endif
        }

      if (!NILP (new_value))
        {
          parent = [FRAME_NS_VIEW (p) window];

          [parent addChildWindow: child
                         ordered: NSWindowAbove];
#if defined (NS_IMPL_COCOA) && MAC_OS_X_VERSION_MAX_ALLOWED >= 101000
#if MAC_OS_X_VERSION_MIN_REQUIRED < 101000

/* *** HERE *** */

          if ([child respondsToSelector:@selector(setAccessibilitySubrole:)]
#endif
              [child setAccessibilitySubrole:NSAccessibilityFloatingWindowSubrole];
#endif
        }



Reply | Threaded
Open this post in threaded view
|

bug#33021: nsterm.m: missing two (2) closing parentheses ...

Lars Ingebrigtsen
Keith David Bershatsky <[hidden email]> writes:

> At the convenience of the Emacs team, please add two (2) closing parentheses to nsterm.m.  While it is possible to build Emacs, working on the functions is difficult because Emacs cannot narrow properly to a defun ....  Thanks.

Could you send a patch for this?  I'm not quite sure what you're
referring to here.

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



Reply | Threaded
Open this post in threaded view
|

bug#33021: nsterm.m: missing two (2) closing parentheses ...

Keith David Bershatsky
In reply to this post by Keith David Bershatsky
It looks like Alan fixed it on 12/01/2018 with 4b176eb86361cff94a223225e8b852adb1accc50.

Both "if" statements to:

if ([child respondsToSelector:@selector(setAccessibilitySubrole:)]

were missing a closing parenthesis, and *accc50 fixed that problem.

As such, it would be appropriate to close out bug 33021 at your convenience.

Keith

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

> Date: [07-11-2019 08:39:52] <11 Jul 2019 17:39:52 +0200>
> From: Lars Ingebrigtsen <[hidden email]>
> To: Keith David Bershatsky <[hidden email]>
> Cc: [hidden email]
> Subject: Re: bug#33021: nsterm.m:  missing two (2) closing parentheses ...
>
> Keith David Bershatsky <[hidden email]> writes:
>
> > At the convenience of the Emacs team, please add two (2) closing parentheses to nsterm.m.  While it is possible to build Emacs, working on the functions is difficult because Emacs cannot narrow properly to a defun ....  Thanks.
>
> Could you send a patch for this?  I'm not quite sure what you're
> referring to here.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no