bug#32318: wdired-test-bug32173-02 fails

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#32318: wdired-test-bug32173-02 fails

Glenn Morris-3
Package: emacs
Severity: minor
Version: 26.1.50

emacs-26 branch at 0252f73, RHEL 7.5, wdired-test-bug32173-02 fails, see
log below. Identical failure on hydra.nixos.org, see eg
https://hydra.nixos.org/build/78668940 .


Running 4 tests (2018-07-30 07:07:31-0700)
Press C-c C-c when finished or C-c ESC to abort changes
   passed  1/4  wdired-test-bug32173-01
Press C-c C-c when finished or C-c ESC to abort changes
Test wdired-test-bug32173-02 backtrace:
  signal(ert-test-failed (((should (equal (dired-get-filename) test-fi
  ert-fail(((should (equal (dired-get-filename) test-file)) :form (equ
  #f(compiled-function () #<bytecode 0x4f7291>)()
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name wdired-test-bug32173-02 :documentatio
  ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :expensi
  ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
  ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
  ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
  eval((ert-run-tests-batch-and-exit (quote (not (or (tag :expensive-t
  command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/wdired-tests" "--eva
  command-line()
  normal-top-level()
Test wdired-test-bug32173-02 condition:
    (ert-test-failed
     ((should
       (equal
        (dired-get-filename)
        test-file))
      :form
      (equal "/tmp/test-dir-wCopj6/bar.c" "/tmp/test-dir-wCopj6/foo.c")
      :value nil :explanation
      (array-elt 21
                 (different-atoms
                  (98 "#x62" "?b")
                  (102 "#x66" "?f")))))
   FAILED  2/4  wdired-test-bug32173-02
Press C-c C-c when finished or C-c ESC to abort changes
   passed  3/4  wdired-test-symlink-name
Press C-c C-c when finished or C-c ESC to abort changes
   failed  4/4  wdired-test-unfinished-edit-01

Ran 4 tests, 3 results as expected, 1 unexpected (2018-07-30 07:07:31-0700)
1 expected failures

1 unexpected results:
   FAILED  wdired-test-bug32173-02



Reply | Threaded
Open this post in threaded view
|

bug#32318: wdired-test-bug32173-02 fails

Ken Brown-6
On 7/30/2018 2:02 PM, Glenn Morris wrote:
> Package: emacs
> Severity: minor
> Version: 26.1.50
>
> emacs-26 branch at 0252f73, RHEL 7.5, wdired-test-bug32173-02 fails, see
> log below. Identical failure on hydra.nixos.org, see eg
> https://hydra.nixos.org/build/78668940 .

I'm seeing the same thing on Cygwin, but only if the test is run from
wdired-tests.elc (which happens by default when you run 'make check').
But the test passes if it is run from wdired-tests.el:

$ make -C test wdired-tests TEST_LOAD_EL=yes
make: Entering directory '/home/kbrown/src/emacs/i686/test'
make[1]: Entering directory '/home/kbrown/src/emacs/i686/test'
   GEN      lisp/wdired-tests.log
Running 3 tests (2018-07-30 14:41:43-0400, selector `(not (tag :unstable))')
Press C-c C-c when finished or C-c ESC to abort changes
    passed  1/3  wdired-test-bug32173-01 (0.426361 sec)
Press C-c C-c when finished or C-c ESC to abort changes
    passed  2/3  wdired-test-bug32173-02 (0.240313 sec)
Press C-c C-c when finished or C-c ESC to abort changes
    passed  3/3  wdired-test-unfinished-edit-01 (0.130247 sec)

Ran 3 tests, 3 results as expected (2018-07-30 14:41:44-0400, 0.797493 sec)

Ken



Reply | Threaded
Open this post in threaded view
|

bug#32318: wdired-test-bug32173-02 fails

Stephen Berman
On Mon, 30 Jul 2018 14:46:51 -0400 Ken Brown <[hidden email]> wrote:

> On 7/30/2018 2:02 PM, Glenn Morris wrote:
>> Package: emacs
>> Severity: minor
>> Version: 26.1.50
>>
>> emacs-26 branch at 0252f73, RHEL 7.5, wdired-test-bug32173-02 fails, see
>> log below. Identical failure on hydra.nixos.org, see eg
>> https://hydra.nixos.org/build/78668940 .
>
> I'm seeing the same thing on Cygwin, but only if the test is run from
> wdired-tests.elc (which happens by default when you run 'make check'). But the
> test passes if it is run from wdired-tests.el:
>
> $ make -C test wdired-tests TEST_LOAD_EL=yes
> make: Entering directory '/home/kbrown/src/emacs/i686/test'
> make[1]: Entering directory '/home/kbrown/src/emacs/i686/test'
>   GEN      lisp/wdired-tests.log
> Running 3 tests (2018-07-30 14:41:43-0400, selector `(not (tag :unstable))')
> Press C-c C-c when finished or C-c ESC to abort changes
>    passed  1/3  wdired-test-bug32173-01 (0.426361 sec)
> Press C-c C-c when finished or C-c ESC to abort changes
>    passed  2/3  wdired-test-bug32173-02 (0.240313 sec)
> Press C-c C-c when finished or C-c ESC to abort changes
>    passed  3/3  wdired-test-unfinished-edit-01 (0.130247 sec)
>
> Ran 3 tests, 3 results as expected (2018-07-30 14:41:44-0400, 0.797493 sec)

I think I've fixed this now, simply by requiring wdired (in emacs-26
951c5a1).

I had run make check several times before pushing the test file and all
tests were as expected, though there were a few byte-compiler warnings.
But after reading your reports, I also tried a batch run on the compiled
file and got the same failure.  Then I stepped through the ert test run
in edebug and found that on the first run from emacs -Q,
wdired-use-interactive-rename was nil at the point of failure, though it
was let-bound to t; on rerunning the test the let-binding held.  I don't
know why that happened, but I guess the autoloads in wdired.el aren't
enough to make sure all variables and functions are defined when used,
though again, I hadn't seen unexpected failures with make check.
Anyway, requiring the library being tested should have been obvious, and
I hope the problem is solved now.

Steve Berman



Reply | Threaded
Open this post in threaded view
|

bug#32318: wdired-test-bug32173-02 fails

Ken Brown-6
On 7/30/2018 6:57 PM, Stephen Berman wrote:
> I think I've fixed this now, simply by requiring wdired (in emacs-26
> 951c5a1).

That fixes it for me.  Thanks.

Ken




Reply | Threaded
Open this post in threaded view
|

bug#32318: wdired-test-bug32173-02 fails

Stephen Berman
On Tue, 31 Jul 2018 08:35:27 -0400 Ken Brown <[hidden email]> wrote:

> On 7/30/2018 6:57 PM, Stephen Berman wrote:
>> I think I've fixed this now, simply by requiring wdired (in emacs-26
>> 951c5a1).
>
> That fixes it for me.  Thanks.
>
> Ken

Thanks for confirming.  If the next Hydra build with this patch also
succeeds, I'll close the bug.

Steve Berman



Reply | Threaded
Open this post in threaded view
|

bug#32318: wdired-test-bug32173-02 fails

Stephen Berman
On Tue, 31 Jul 2018 14:40:50 +0200 Stephen Berman <[hidden email]> wrote:

> On Tue, 31 Jul 2018 08:35:27 -0400 Ken Brown <[hidden email]> wrote:
>
>> On 7/30/2018 6:57 PM, Stephen Berman wrote:
>>> I think I've fixed this now, simply by requiring wdired (in emacs-26
>>> 951c5a1).
>>
>> That fixes it for me.  Thanks.
>>
>> Ken
>
> Thanks for confirming.  If the next Hydra build with this patch also
> succeeds, I'll close the bug.

I haven't seen a Hydra build of emacs-26 with this patch, but master
succeeds with it (https://hydra.nixos.org/build/79086820/log), so I'm
closing the bug.

Steve Berman