bug#30083: 26.0.90; Let hl-line ignore text with non-default backgrond color

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#30083: 26.0.90; Let hl-line ignore text with non-default backgrond color

zhang cc
hl-line mode adds an overlay face to text of the current line.
The hl-line usually only replace the background color of the text to
another color which is similar to default background color with small
diffrence.
It works well for text with default background color, but not for text
with non-default color. The latter usually is highlight faces like face
for TODO in org-mode, matched items in search results. They have
reversed fg/bg colors with default face. Their background colors
are similar with foreground color of default face. Their foreground
colors are similar with background color of default face and background
color of hl-line. Then if hl-line changes background color, then their
foreground and background colors are too similar and make the text hardly
be seen.
Text with these faces are important to user. But hl-lime dim them and
even makes them can't be seen. If hl-line ignores these text(with
non-default background), then it will be good.

Tried with 'distant color' for hl-line face, and it didn't work well for
many colors. Even if it works well, it is not perfect solution for this
problem.


Reply | Threaded
Open this post in threaded view
|

bug#30083: 26.0.90; Let hl-line ignore text with non-default backgrond color

zhang cc
I changed the affected faces to use inverse-video, then hl-line only modified the foreground color of the text, which is better than before.
What is the purpose of inverse-video? When it should be used?

Reply | Threaded
Open this post in threaded view
|

bug#30083: 26.0.90; Let hl-line ignore text with non-default backgrond color

Eli Zaretskii
> From: zhang cc <[hidden email]>
> Date: Fri, 12 Jan 2018 03:29:47 +0000
>
> What is the purpose of inverse-video? When it should be used?

It should be used for stuff like mode line, which needs to have text
stand out without specifying specific colors.