bug#29291: tramp-test24-file-acl fails on hydra.nixos.org

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#29291: tramp-test24-file-acl fails on hydra.nixos.org

Glenn Morris-3
Package: emacs
Severity: minor

Hi - just in case you missed it, tramp-test24-file-acl fails on
hydra.nixos.org:

https://hydra.nixos.org/build/64073249

Test tramp-test24-file-acl condition:
    (ert-test-failed
     ((should
       (string-equal
       (file-acl tmp-name1)
       (file-acl tmp-name3)))
      :form
      (string-equal "user::rwx
group::rwx
other::rwx
" "user::r--
group::r--
other::r--
")
      :value nil))
   FAILED  32/60  tramp-test24-file-acl




Reply | Threaded
Open this post in threaded view
|

bug#29291: tramp-test24-file-acl fails on hydra.nixos.org

Michael Albinus
Glenn Morris <[hidden email]> writes:

Hi Glenn,

> Hi - just in case you missed it, tramp-test24-file-acl fails on
> hydra.nixos.org:
>
> https://hydra.nixos.org/build/64073249
>
> Test tramp-test24-file-acl condition:
>     (ert-test-failed
>      ((should
>        (string-equal
>        (file-acl tmp-name1)
>        (file-acl tmp-name3)))
>       :form
>       (string-equal "user::rwx
> group::rwx
> other::rwx
> " "user::r--
> group::r--
> other::r--
> ")
>       :value nil))
>    FAILED  32/60  tramp-test24-file-acl

Should be fixed now.

Best regards, Michael.



Reply | Threaded
Open this post in threaded view
|

bug#29291: tramp-test24-file-acl fails on hydra.nixos.org

Michael Albinus
Michael Albinus <[hidden email]> writes:

Hi Glenn,

>> https://hydra.nixos.org/build/64073249
>
> Should be fixed now.

I've tried to check myself on hydra, but there is no jobset for
emacs-26. What is missing to install this?

Best regards, Michael.



Reply | Threaded
Open this post in threaded view
|

bug#29291: tramp-test24-file-acl fails on hydra.nixos.org

Glenn Morris-3
Michael Albinus wrote:

> I've tried to check myself on hydra, but there is no jobset for
> emacs-26. What is missing to install this?

Someone just needs to ask hydra-users to add it.

I haven't bothered because the Emacs project as a whole seems to have
little interest in hydra.nixos.org, eg apparently having decided to
replace it with some Emacs-specific replacement that doesn't exist yet.
And hydra jobs often remain broken for weeks at a time, due to trivial
mistakes in Emacs, and no-one seems to care (I know you do look at Tramp
issues there).

Or you could merge emacs-26 to master, which would be quicker! :)



Reply | Threaded
Open this post in threaded view
|

bug#29291: tramp-test24-file-acl fails on hydra.nixos.org

Michael Albinus
In reply to this post by Glenn Morris-3
Glenn Morris <[hidden email]> writes:

Hi Glenn,

> I haven't bothered because the Emacs project as a whole seems to have
> little interest in hydra.nixos.org, eg apparently having decided to
> replace it with some Emacs-specific replacement that doesn't exist yet.
> And hydra jobs often remain broken for weeks at a time, due to trivial
> mistakes in Emacs, and no-one seems to care (I know you do look at Tramp
> issues there).

The problem with hydra is that notifications are not visible
prominently. Yes, there are emails from the Hydra Build Daemon. But they
are unspecific, I cannot see immediately whether I'm concerned. Often, I
check whether Tramp tests have failed, or something else I've
modified. But this takes too much time, so it is not integrated into the
workflow of most Emacs developers.

When the email could mention which test case or file has failed, in the
subject of the email, more people would care I believe. Or, even more
drastic, an Emacs bug shall be generated *automatically*, like the one
we are discussing here.

> Or you could merge emacs-26 to master, which would be quicker! :)

Well, I don't feel much comfortable with git, so I fear I could damage
something during merge. That's why I haven't done it yet. But thanks,
that you have performed it.

Looks like tramp-test24-file-acl still fails. Hmm, maybe there is a
serious Tramp bug, indeed. I'll continue to dig. For faster progress,
I'll add my traces in the master branch.

Best regards, Michael.



Reply | Threaded
Open this post in threaded view
|

bug#29291: tramp-test24-file-acl fails on hydra.nixos.org

Michael Albinus
Michael Albinus <[hidden email]> writes:

Hi Glenn,

> Looks like tramp-test24-file-acl still fails. Hmm, maybe there is a
> serious Tramp bug, indeed. I'll continue to dig. For faster progress,
> I'll add my traces in the master branch.

I believe I've nailed it down, finally. After next merge with emacs-26,
the error shall disappear on hydra.

Best regards, Michael.



Reply | Threaded
Open this post in threaded view
|

bug#29291: tramp-test24-file-acl fails on hydra.nixos.org

Glenn Morris-3
Michael Albinus wrote:

> I believe I've nailed it down, finally. After next merge with emacs-26,
> the error shall disappear on hydra.

Thanks. admin/gitmerge.el makes merging straightforward, so consider
giving it a go next time.