bug#28788: macOS frame-list-z-order fails to list frames when called with a DISPLAY argument

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#28788: macOS frame-list-z-order fails to list frames when called with a DISPLAY argument

Robert Weiner-2
emacs-version
"27.0.50"

system-type
darwin

(frame-list-z-order)
(#<frame *scratch* "~/" 0x104ae0d38> #<frame TAGS<bk> "/Users/bk/" 0x1015f3e48> #<frame *Help* "~/" 0x1014b8000> #<frame TAGS<bk> "/Users/bk/" 0x11f959e40> #<frame TAGS<bk> "/Users/bk/" 0x101564fb0> 2111061947183245)

(x-display-list)
("bka-iMac.local")

;; Result should be the same as frame-list-z-order called without an
;; argument since we have only 1 display connection, but it isn't.
(frame-list-z-order (car (x-display-list)))
nil
Reply | Threaded
Open this post in threaded view
|

bug#28788: macOS frame-list-z-order fails to list frames when called with a DISPLAY argument

Eli Zaretskii
> From: Robert Weiner <[hidden email]>
> Date: Wed, 11 Oct 2017 15:35:56 -0400
>
> (frame-list-z-order)
> (#<frame *scratch* "~/" 0x104ae0d38> #<frame TAGS<bk> "/Users/bk/" 0x1015f3e48> #<frame *Help* "~/"
> 0x1014b8000> #<frame TAGS<bk> "/Users/bk/" 0x11f959e40> #<frame TAGS<bk> "/Users/bk/"
> 0x101564fb0> 2111061947183245)
>
> (x-display-list)
> ("bka-iMac.local")
>
> ;; Result should be the same as frame-list-z-order called without an
> ;; argument since we have only 1 display connection, but it isn't.

I don't understand why you expected the same results: the former
returns a list of frames, the latter the list of _X_displays_.



Reply | Threaded
Open this post in threaded view
|

bug#28788: macOS frame-list-z-order fails to list frames when called with a DISPLAY argument

Alan Third
In reply to this post by Robert Weiner-2
On Wed, Oct 11, 2017 at 03:35:56PM -0400, Robert Weiner wrote:

> emacs-version
> "27.0.50"
>
> system-type
> darwin
>
> (frame-list-z-order)
> (#<frame *scratch* "~/" 0x104ae0d38> #<frame TAGS<bk> "/Users/bk/"
> 0x1015f3e48> #<frame *Help* "~/" 0x1014b8000> #<frame TAGS<bk> "/Users/bk/"
> 0x11f959e40> #<frame TAGS<bk> "/Users/bk/" 0x101564fb0> 2111061947183245)
>
> (x-display-list)
> ("bka-iMac.local")
>
> ;; Result should be the same as frame-list-z-order called without an
> ;; argument since we have only 1 display connection, but it isn't.
> (frame-list-z-order (car (x-display-list)))
> nil

Fix pushed to emacs 26.

Since DISPLAY is irrelevant here I’ve changed it to behave like the
Windows version and return the full list unless the argument is a
frame.
--
Alan Third



Reply | Threaded
Open this post in threaded view
|

bug#28788: macOS frame-list-z-order fails to list frames when called with a DISPLAY argument

martin rudalics
 > Since DISPLAY is irrelevant here I’ve changed it to behave like the
 > Windows version and return the full list unless the argument is a
 > frame.

Thanks.  While you're there, could you also try fixing the return value
of

(frame-parameter nil 'display)

This would be needed to fix Bug#25901: 25.2; fit-frame-to-buffer not
functional in OS X.

martin