bug#25424: 25.1; sql-mode, product mysql: sql-end-of-statement: Wrong type argument: stringp, nil

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#25424: 25.1; sql-mode, product mysql: sql-end-of-statement: Wrong type argument: stringp, nil

Tijs Mallaerts
To reproduce:
- activate sql-mode
- call M-x sql-set-product
- select mysql
- write a part of a query, f.ex. select * from
- call M-x sql-end-of-statement

Error: sql-end-of-statement: Wrong type argument: stringp, nil

A missing :terminator sql-product-feature of mysql seems to be causing this issue.

In GNU Emacs 25.1.4 (x86_64-unknown-linux-gnu)
 of 2016-09-24 built on kubuntu
Windowing system distributor 'The X.Org Foundation', version 11.0.11804000
System Description:    Ubuntu 16.04.1 LTS

Configured using:
 'configure --with-x-toolkit=no'

Configured features:
XPM JPEG TIFF GIF PNG SOUND DBUS GSETTINGS NOTIFY LIBXML2 FREETYPE XFT
ZLIB X11

Important settings:
  value of $LC_MONETARY: nl_BE.UTF-8
  value of $LC_NUMERIC: nl_BE.UTF-8
  value of $LC_TIME: nl_BE.UTF-8
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: SQL[MySQL]
Reply | Threaded
Open this post in threaded view
|

bug#25424: [PATCH] Add mysql terminator to sql-product-alist

Tijs Mallaerts
From b97f29e248a57aea4fe92a606bdd67d2ab274c91 Mon Sep 17 00:00:00 2001
From: tijsmallaerts <[hidden email]>
Date: Fri, 11 Jan 2019 23:05:36 +0100
Subject: [PATCH] Add mysql terminator to sql-product-alist

---
 lisp/progmodes/sql.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el
index ebde684109..42c4ab4e9f 100644
--- a/lisp/progmodes/sql.el
+++ b/lisp/progmodes/sql.el
@@ -459,7 +459,8 @@ file.  Since that is a plaintext file, this could be dangerous."
      :prompt-length 6
      :prompt-cont-regexp "^    -> "
      :syntax-alist ((?# . "< b"))
-     :input-filter sql-remove-tabs-filter)
+     :input-filter sql-remove-tabs-filter
+     :terminator ";")
 
     (oracle
      :name "Oracle"
--
2.17.1
Reply | Threaded
Open this post in threaded view
|

bug#25424: Add mysql terminator to sql-product-alist

Tijs Mallaerts
In reply to this post by Tijs Mallaerts
I've sent a patch to fix bug 25424 directly to the bug entry of the bug tracker. Is that the correct place to send the patch to, or is it recommended to email patches to this mailing list?

Thank you!
Tijs