bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'

Drew Adams
See bug #20625.

Summary:

bookmark.el uses `define-error' without passing a string for argument
MESSAGE.

Emacs Dev had decided that this is incorrect usage, and thus that
`define-error' does not provide the same functionality as you get by
using property `error-conditions' directly.

Either change the bookmark.el code to use `error-conditions' directly
(as before) or change it to provide a string MESSAGE arg for the
definition of `bookmark-errors'.


In GNU Emacs 25.0.90.4 (i686-w64-mingw32)
 of 2016-03-20
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --host=i686-w64-mingw32 --without-dbus
 --without-compress-install CFLAGS=-static'



Reply | Threaded
Open this post in threaded view
|

bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'

Stefan Kangas
Drew Adams <[hidden email]> writes:
> bookmark.el uses `define-error' without passing a string for argument
> MESSAGE.
>
> Emacs Dev had decided that this is incorrect usage, and thus that
> `define-error' does not provide the same functionality as you get by
> using property `error-conditions' directly.

The attached patch should fix this.

Thanks,
Stefan Kangas

0001-Add-MESSAGE-string-to-bookmark-errors-bug-23408.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'

Drew Adams
> The attached patch should fix this.


LGTM. Thx.



Reply | Threaded
Open this post in threaded view
|

bug#23408: 25.0.90; bookmark.el: incorrect use of `define-error'

Noam Postavsky
tags 23408 fixed
close 23408 27.1
quit

Drew Adams <[hidden email]> writes:

>> The attached patch should fix this.
>
>
> LGTM. Thx.

Pushed to master.

cdd8cb3a9e 2019-06-15T17:08:58-04:00 "Add MESSAGE string to bookmark-errors (bug#23408)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cdd8cb3a9e18f87da31e52236fd2c4ebfcd676bd