bug#11995: vc-compilation-mode name and implementation

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

bug#11995: vc-compilation-mode name and implementation

Dan Nicolaescu-4

The newly added vc-compilation-mode function does not have the best
name, -mode functions stand for modes, this is not one.

Currently the preferred way to define modes is to use `defined-derived-mode'...

Also the implementation seems to be a bit more complicated than needed:
there

Defining a vc-default-compilation-mode function should simplify the
implementation.  vc-make-backend-sym is something that very few things
need to call.

I'm leaving on vacation, so I won't be able to do much about this for a while.









Reply | Threaded
Open this post in threaded view
|

bug#11995: vc-compilation-mode name and implementation

Lars Ingebrigtsen
Dan Nicolaescu <[hidden email]> writes:

> The newly added vc-compilation-mode function does not have the best
> name, -mode functions stand for modes, this is not one.

(I'm going through old bug reports that unfortunately got no response at
the time.)

It is perhaps not an ideal name, but it's probably too late to change
now, though.

> Currently the preferred way to define modes is to use
> `defined-derived-mode'...
>
> Also the implementation seems to be a bit more complicated than needed:
> there
>
> Defining a vc-default-compilation-mode function should simplify the
> implementation.  vc-make-backend-sym is something that very few things
> need to call.

I think it looks like something was left out of this message?  I'm not
sure what this is referring to.

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



Reply | Threaded
Open this post in threaded view
|

bug#11995: vc-compilation-mode name and implementation

Lars Ingebrigtsen
Lars Ingebrigtsen <[hidden email]> writes:

>> Defining a vc-default-compilation-mode function should simplify the
>> implementation.  vc-make-backend-sym is something that very few things
>> need to call.
>
> I think it looks like something was left out of this message?  I'm not
> sure what this is referring to.

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no