Re: master b2790db 2/2: Improve errors & warnings due to fancy quoted vars (Bug#32939)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: master b2790db 2/2: Improve errors & warnings due to fancy quoted vars (Bug#32939)

Stefan Monnier
> --- a/lisp/help.el
> +++ b/lisp/help.el
[...]
> +;; Just some quote-like characters for now.  TODO: generate this stuff
> +;; from official Unicode data.
> +(defconst uni-confusables
[...]
> +(defconst uni-confusables-regexp

Please try and stick to the namespace prefix corresponding to the file.

Should we incorporate GNU ELPA's `uni-confusables` into Emacs?


        Stefan


Reply | Threaded
Open this post in threaded view
|

Re: master b2790db 2/2: Improve errors & warnings due to fancy quoted vars (Bug#32939)

Noam Postavsky
On Thu, 28 Nov 2019 at 18:32, Stefan Monnier <[hidden email]> wrote:

> > +++ b/lisp/help.el

> > +(defconst uni-confusables
> [...]
> > +(defconst uni-confusables-regexp
>
> Please try and stick to the namespace prefix corresponding to the file.

Right, fixed and added docstrings.

[1: 966abdba09]: 2019-12-13 06:41:05 -0500
  Add prefix to help.el uni-confusable* vars
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=966abdba09214813a86979f22bfb08475a73f10c

> Should we incorporate GNU ELPA's `uni-confusables` into Emacs?

I think I had looked at doing that briefly, but couldn't figure out
how to make use of it.