Re: master 4eb7db5: Mouse rectangular region selection (bug#38013)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: master 4eb7db5: Mouse rectangular region selection (bug#38013)

Stefan Monnier
[ Please don't take the below personally.  ]

> +(defun mouse-drag-region-rectangle (start-event)
> +  "Set the region to the rectangle that the mouse is dragged over.
> +This must be bound to a button-down mouse event."
> +  (interactive "e")
[...]

Yuck!  We *really* need to abstract that gunk into its own function so
we don't keep copying it between the various `FOO-drag-region` functions.


        Stefan


Reply | Threaded
Open this post in threaded view
|

Re: master 4eb7db5: Mouse rectangular region selection (bug#38013)

Mattias Engdegård-2
27 nov. 2019 kl. 23.10 skrev Stefan Monnier <[hidden email]>:

> Yuck!  We *really* need to abstract that gunk into its own function so
> we don't keep copying it between the various `FOO-drag-region` functions.

No disagreement here! Refactoring should proceed with care, though, as there may be some subtle differences.