Re: emacs-26 4387bb4 1/3: Update authors

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: emacs-26 4387bb4 1/3: Update authors

Glenn Morris-3
Nicolas Petton wrote:

> branch: emacs-26
> commit 4387bb44ae59853feab94b72ec568b73ad1f827a
[...]

> --- a/admin/authors.el
> +++ b/admin/authors.el
> @@ -130,6 +130,7 @@ files.")
>      ("Agustín Martín" "Agustin Martin" "Agustín Martín Domingo")
>      ("Martin Lorentzon" "Martin Lorentzson")
>      ("Matt Swift" "Matthew Swift")
> +    (nil "Max")
>      ("Maxime Edouard Robert Froumentin" "Max Froumentin")
>      ("Michael R. Mauger" "Michael Mauger")
>      ("Michael D. Ernst" "Michael Ernst")

Hi - this is too broad. It excludes anyone whose name includes "Max", viz:

> -Doug Maxey: changed mouse.el
[...]
> -Maxime Edouard Robert Froumentin: changed gnus-art.el mml.el
> -
> -Max Mikhanosha: changed org-agenda.el org-habit.el org.el

Reply | Threaded
Open this post in threaded view
|

Re: emacs-26 4387bb4 1/3: Update authors

Glenn Morris-3

PS similar thing here due to too-broad "Bastien" entry in authors-aliases:

> -Sébastien Delafond: changed org.el
> -
> -Sébastien Gross: changed hideshow.el
> -
> -Sebastien Kirche: changed mail-extr.el
> -
> -Sébastien Vauban: changed org.el org-agenda.el ox-latex.el ob-core.el
> -  org-clock.el ox-ascii.el ox-html.el
> -

Reply | Threaded
Open this post in threaded view
|

Re: emacs-26 4387bb4 1/3: Update authors

Glenn Morris-3

PPS (Sorry for all the mails). I would suggest reviewing all those
entries, eg these are probably also problematic:
(nil "felix")
(nil "cg")

Reply | Threaded
Open this post in threaded view
|

Re: emacs-26 4387bb4 1/3: Update authors

Nicolas Petton-2
In reply to this post by Glenn Morris-3
Glenn Morris <[hidden email]> writes:

Hi Glenn,

> Hi - this is too broad. It excludes anyone whose name includes "Max",
> viz:

Indeed, I'll change it (I contacted the author of the commit) to get his
full name.

Cheers,
Nico

signature.asc (497 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: emacs-26 4387bb4 1/3: Update authors

Nicolas Petton-2
In reply to this post by Glenn Morris-3
Glenn Morris <[hidden email]> writes:

> PPS (Sorry for all the mails). I would suggest reviewing all those
> entries, eg these are probably also problematic:
> (nil "felix")
> (nil "cg")

Indeed, they are.  FWIW, I changed the new entry from "Max" to his email
address, which works as expected.

Cheers,
Nico

signature.asc (497 bytes) Download Attachment