Re: [PATCH] pcase.el: Add type pattern

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] pcase.el: Add type pattern

Eric Abrahamsen-2
Adam Porter <[hidden email]> writes:

> Hi,
>
> It seemed like an obvious and useful improvement to add a "type" pattern
> to pcase, so I prepared this patch.  I wondered if checking for
> predicates like this was a good way to do so, and I saw that the
> cl-typep inliner does basically this, so it seems reasonable.

One thing that's nice about cl-typep is that it will correctly identify
instances of subclasses, which can be nice. Dunno how difficult it might
be to work that in there, but it's something to consider. Either way
this is a nice addition.