Emacs master commit: "Add current-line in simple.el" - Wrong commit log?

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Emacs master commit: "Add current-line in simple.el" - Wrong commit log?

Kaushal Modi
The commit heading and body refer to a new function called current-line.

But the commit is basically adding a new optional arg absolute-p to line-number-at-pos; I do not see any reference to a new function current-line in the actual commit.

http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=ae98cdf9431604d0f722f1db217ca06debfbb7b6
--

Kaushal Modi

Reply | Threaded
Open this post in threaded view
|

Re: Emacs master commit: "Add current-line in simple.el" - Wrong commit log?

Nicolas Petton-2
Kaushal Modi <[hidden email]> writes:

> The commit heading and body refer to a new function called current-line.
>
> But the commit is basically adding a new optional arg absolute-p to
> line-number-at-pos; I do not see any reference to a new function
> current-line in the actual commit.

Indeed, the patch got revised a few times, and I forgot to double-check
the commit message when applying it.

Cheers,
Nico

signature.asc (482 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Emacs master commit: "Add current-line in simple.el" - Wrong commit log?

Nicolas Petton-2
In reply to this post by Kaushal Modi
Kaushal Modi <[hidden email]> writes:

> The commit heading and body refer to a new function called current-line.
>
> But the commit is basically adding a new optional arg absolute-p to
> line-number-at-pos; I do not see any reference to a new function
> current-line in the actual commit.

I'll revert the commit.  Damien, can you provide another patch?

Cheers,
Nico

signature.asc (482 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Emacs master commit: "Add current-line in simple.el" - Wrong commit log?

Kaushal Modi
In reply to this post by Nicolas Petton-2
On Mon, Jun 19, 2017 at 8:41 AM Nicolas Petton <[hidden email]> wrote:
Indeed, the patch got revised a few times, and I forgot to double-check
the commit message when applying it.

Thanks! That explains :) 

Also, if the back-story of this commit is a bug report, it would be useful to have "(Bug#NNNNN)" in the commit log.

--

Kaushal Modi

Reply | Threaded
Open this post in threaded view
|

Re: Emacs master commit: "Add current-line in simple.el" - Wrong commit log?

Damien Cassou-2
In reply to this post by Nicolas Petton-2
Nicolas Petton <[hidden email]> writes:
> I'll revert the commit.  Damien, can you provide another patch?

Here is a new version. I took the opportunity to add a NEWS entry
and to reflect the change in the elisp manual. Please double-check
everything.

--
Damien Cassou
Företagsplatsen AB
Phone/Fax: +46 (0)8 774 63 00
Mobile: +33 (0)6 80 50 18 91
Address: Skeppsbron 26, 4tr, SE-111 30 Stockholm
Web: www.foretagsplatsen.se

0001-Add-absolute-p-optional-parameter-to-line-number-at-.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Emacs master commit: "Add current-line in simple.el" - Wrong commit log?

Nicolas Petton-2
Damien Cassou <[hidden email]> writes:

> Here is a new version. I took the opportunity to add a NEWS entry
> and to reflect the change in the elisp manual.

Great, thanks!

> -(defun line-number-at-pos (&optional pos)
> -  "Return (narrowed) buffer line number at position POS.
> +(defun line-number-at-pos (&optional pos absolute-p)

Why not simply `absolute' instead of `absolute-p'. It's not a predicate,
is it?

Cheers,
Nico

signature.asc (482 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Emacs master commit: "Add current-line in simple.el" - Wrong commit log?

Damien Cassou-2
Nicolas Petton <[hidden email]> writes:
> Why not simply `absolute' instead of `absolute-p'. It's not a
> predicate, is it?

fixed.

--
Damien Cassou
http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

0001-Add-absolute-optional-parameter-to-line-number-at-.patch (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Emacs master commit: "Add current-line in simple.el" - Wrong commit log?

Nicolas Petton-2
Damien Cassou <[hidden email]> writes:

> Nicolas Petton <[hidden email]> writes:
>> Why not simply `absolute' instead of `absolute-p'. It's not a
>> predicate, is it?
>
> fixed.

Thanks, I installed you patch in master.

Cheers,
Nico

signature.asc (482 bytes) Download Attachment