Bug#25949 is not fixed on MS-Windows

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Bug#25949 is not fixed on MS-Windows

Eli Zaretskii
The test for this bug still fails:

  Test files-tests--file-name-non-special--subprocess backtrace:
  Test files-tests--file-name-non-special--subprocess condition:
      (file-error "Setting current directory" "Permission denied" "/:d:/")
     FAILED  7/7  files-tests--file-name-non-special--subprocess

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug#25949 is not fixed on MS-Windows

Fabrice Popineau-4
The following patch fixes it :

diff --git a/src/callproc.c b/src/callproc.c
index 70d144f83f..185a05af0d 100644
--- a/src/callproc.c
+++ b/src/callproc.c
@@ -120,14 +120,14 @@ encode_current_directory (void)
   if (NILP (dir))
     dir = build_string ("~");

-  dir = expand_and_dir_to_file (dir, Qnil);
+  dir = expand_and_dir_to_file (remove_slash_colon (dir), Qnil);

   if (NILP (Ffile_accessible_directory_p (dir)))
     report_file_error ("Setting current directory",
                        BVAR (current_buffer, directory));

   /* Remove "/:" from DIR and encode it.  */
-  dir = ENCODE_FILE (remove_slash_colon (dir));
+  dir = ENCODE_FILE (dir);

   if (! file_accessible_directory_p (dir))
     report_file_error ("Setting current directory",


but is it correct ?

Fabrice


2017-08-01 17:24 GMT+02:00 Eli Zaretskii <[hidden email]>:
The test for this bug still fails:

  Test files-tests--file-name-non-special--subprocess backtrace:
  Test files-tests--file-name-non-special--subprocess condition:
      (file-error "Setting current directory" "Permission denied" "/:d:/")
     FAILED  7/7  files-tests--file-name-non-special--subprocess




--
Fabrice Popineau
-----------------------------
CentraleSupelec
Département Informatique
3, rue Joliot Curie
91192 Gif/Yvette Cedex
Tel direct : +33 (0) 169851950
Standard : +33 (0) 169851212
------------------------------

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug#25949 is not fixed on MS-Windows

Eli Zaretskii
> From: Fabrice Popineau <[hidden email]>
> Date: Tue, 1 Aug 2017 22:26:01 +0200
> Cc: Philipp <[hidden email]>, Emacs developers <[hidden email]>
>
> The following patch fixes it :

Thanks, but I don't think this is the right fix.  The problem is that
the test sets the default directory to "/:/", which is invalid on
Windows.  It should set the default directory to something like
"/:c:/" instead.

I fixed the test along those lines.

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug#25949 is not fixed on MS-Windows

Fabrice Popineau-3


2017-08-05 10:41 GMT+02:00 Eli Zaretskii <[hidden email]>:
> From: Fabrice Popineau <[hidden email]>
> Date: Tue, 1 Aug 2017 22:26:01 +0200
> Cc: Philipp <[hidden email]>, Emacs developers <[hidden email]>
>
> The following patch fixes it :

Thanks, but I don't think this is the right fix.  The problem is that
the test sets the default directory to "/:/", which is invalid on
Windows.  It should set the default directory to something like
"/:c:/" instead.

I fixed the test along those lines.

Ok. Thanks.
Loading...